Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1479876img; Tue, 19 Mar 2019 08:30:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqx5hQoEuin0GTx6zyL38vl9acz5XUdx/I2G7Lzo+xDl3mq5b4L7EXkMRkED37O4TXXSixiJ X-Received: by 2002:a62:7042:: with SMTP id l63mr2481342pfc.1.1553009409760; Tue, 19 Mar 2019 08:30:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553009409; cv=none; d=google.com; s=arc-20160816; b=w5k2z62GzJjpSCX+D5ejsNyqL3h2OMsJKL+wsACm3KPf97iKE7pV7RNBa/ZkC8X5vT 82+DGA9/LxcpgmaIC1dGClDwrtZ2lBv4Bce9dtxQtwJivV05yeVzz6rHaxLdFQh35r66 yVCTN8mAvnAjq8h4/bE7Cdw4wuNdyjyfBhutwDXvE+NZzeNK3kn+Oe0vDKaDxKFdl8bK nSEgWWsEGueK8h9PsP/wIzW56doYX+N0fmaRpB4t6RksVvWPXUACqMKmQyUZFU10+rRo WmBdARoH8U/BdcuUacVY9KtI+g9J7LP1SM5bJhzEO2um99B1X66Z/UzfzY7+PBYf53t2 SYeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=M3YgC4PQ3oC3wovMHbKlK0mpQFq3laS/+t0XN7D5y+g=; b=00FVvM7gSPSA2tXh4IVqASPtiw9d0QMjf97PO8qS2UxzNgu2rj1l2VouwyoH2p93Zh 9XIsu7NdCJ0Xdfr82KTYw83CLkggOIRdzpAqg/zglbAZ6bEAM16S9bvP1DT8qs+Ual09 26L1fYgLSKhp1KPbBcGTCniQRkFP3Pbkf00x+Jsqkfg2jED6oSf5YKefn6M76B53wNvx YwKayvTY3cDFbuwm3BspzrwQN89IoA0MR4J6QdbuX/CXhArfxS0bjuCluJ8Obu8fzqus rRQ/XvfAZfQ0pBmuDeKecvXLafkMXfWQKlfofMoRQzoGf8FbnEnr/2ER+XRhg/vDUaL6 NL4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b="Cexcw/s1"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f67si11687270pgc.182.2019.03.19.08.29.54; Tue, 19 Mar 2019 08:30:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b="Cexcw/s1"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727508AbfCSP3M (ORCPT + 99 others); Tue, 19 Mar 2019 11:29:12 -0400 Received: from merlin.infradead.org ([205.233.59.134]:42226 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbfCSP3L (ORCPT ); Tue, 19 Mar 2019 11:29:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=M3YgC4PQ3oC3wovMHbKlK0mpQFq3laS/+t0XN7D5y+g=; b=Cexcw/s1HW2/nYjJCLRTHRRZw IgPgO0b84ZDEskK7ObbqDYf29BYkHbcpIkn+m0ReMmlG9VpxGvjouKvhHJ2bkpjOHUo7sPRDw4BUu 4fA3jYkcqPG9DM2qYjBJmm7fo1BLTDIFSXkUWyx1qBpfkAGYvaRIIhYamoi9ltcr2Jihef/uLbh6n IHLOZDNd+RvITBnR4LzgVr3YBsMSn0sPf6ERfbWTwh7U/8Gwqp2MCKb5Q/OD+hW3sD2+JwgDz7K9M J9d/W0BwGBbxeFoEb0X1AAd8UqpOsxp/xS/EnTKaUcbXGzyebRa8J2sqcX1G06fWH/ldFDZrzzgrA XQVFpW1fg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6Gfp-0001ig-S5; Tue, 19 Mar 2019 15:29:06 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8A7FE28295A3F; Tue, 19 Mar 2019 16:29:03 +0100 (CET) Date: Tue, 19 Mar 2019 16:29:03 +0100 From: Peter Zijlstra To: kan.liang@linux.intel.com Cc: acme@kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, jolsa@kernel.org, eranian@google.com, alexander.shishkin@linux.intel.com, ak@linux.intel.com Subject: Re: [PATCH 11/22] perf/core: Support a REMOVE transaction Message-ID: <20190319152903.GJ5996@hirez.programming.kicks-ass.net> References: <20190318214144.4639-1-kan.liang@linux.intel.com> <20190318214144.4639-12-kan.liang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190318214144.4639-12-kan.liang@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 18, 2019 at 02:41:33PM -0700, kan.liang@linux.intel.com wrote: > From: Andi Kleen > > For TopDown metrics it is useful to have a remove transaction when > the counter is unscheduled, so that the value can be saved correctly. > Add a remove transaction to the perf core. That needs more explaining.