Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1524863img; Tue, 19 Mar 2019 09:25:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqwcOnTk0c0zkoECMkLiXKkRuVKGuv4s04Wvh/un8bd45zv8T59QBjG5mwZiukdgy0KpgQxn X-Received: by 2002:a17:902:bb90:: with SMTP id m16mr3020997pls.49.1553012747862; Tue, 19 Mar 2019 09:25:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553012747; cv=none; d=google.com; s=arc-20160816; b=Oa0Ypud5pQuZV0AyXyEsoSJMRJnT4lqH9DUVpe0RKKQeY4pPrSfcnsHAb6nDFuqd+c 4rq3/w72Ry01B+JX6JuHEYNiUSn+nx8+/Zcpbz1I1u8KKR/+/dQGYRqEENDz3yUbzhrJ 955WrS1ErKJpi2b8gLNmxpDQMkoAgO/Iz7q4EI/iQExY4TjygtLy6wjT5Hg2Vjci3oAj 5CeHz+oKk7SrsJb9OwWtYy7/MrdS2m4YBnbFCO9h1VizdLw8awlZBwNGwq9KeDJD9dPu +NNqu4432OALIBzF9dFqvt3VR6F+2nBb1M4hBPm+lGgYBzvoy1wDUdlD8ejsu/Fo7Dkp Ejbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=nriVN6CznBWnvaz1cniK33cl59dItJ09H9B96QgY3HE=; b=q0NLws4D1x/PKPOcvQrs/+FbA12WOstgEI/P3EJW2YNCBCynkRgrHY7cXSN4o/A1SR o57tDOQIeHmb/30HEZydtMcG28FW/cYNlIIjKrlq3C9Ml1IWr5XHThIINL7qIWBbax2J AqQOTlk3Ruda/X7E4kFG6gQ4sk6hglwMakilhRABauuomZTTPZeoQ8WD16O9dWF7QunA w+iY+DWugTLc5UvWsYAJvdBPAobSHlbVSMM/Uk76H8zzbvqeaoemMqnRaNCGO22Vopkl xxaEm+XdFBra0xeyyJrOol7ZVifQ+RE11cHJhOpzXAEPngjmpctcx3q5XU5QB7NcCUil gjLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=NfmZbSOY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q19si11634364pgi.554.2019.03.19.09.25.32; Tue, 19 Mar 2019 09:25:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=NfmZbSOY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727950AbfCSQYS (ORCPT + 99 others); Tue, 19 Mar 2019 12:24:18 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:41987 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727914AbfCSQYP (ORCPT ); Tue, 19 Mar 2019 12:24:15 -0400 Received: by mail-pg1-f195.google.com with SMTP id p6so1371298pgh.9; Tue, 19 Mar 2019 09:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=nriVN6CznBWnvaz1cniK33cl59dItJ09H9B96QgY3HE=; b=NfmZbSOY4jmzet2MQdvs9yXkhWN07iLrvtK3IKNjVHdUFHLNTQUBRCKXgGfI0Lyhh8 lmnaURKctCpM/Y5eBLdclkxPUHVuz7pmRivFuRv3b3Z65Xi1ld4S4573U9sY5OwAt/h5 0qbhtApyk1oOLIYpxeOL/wLuXm4A/hOsnqjxSW8IDx8vu1UZKTtLSjOi5JuKmZ9kPJms kyvHtTDzTZUb8NSIb9Ty+nPvLeR4FpQyGgQf9ga3YbWB7VCSLbukjWp+kA7taBFSl88l eLVYPyOWVIg6HZ668HAChT9JElcwTf+1qLfOZaUJhcBU5RDue+sfZC5YYtviTt2I0Tod a53w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nriVN6CznBWnvaz1cniK33cl59dItJ09H9B96QgY3HE=; b=pEoYZfnbnVwlV2SALFWBWUzoLlqoa3n4AeQ5WwOHYLbicp1j9WiOLaRSBHmoWp2wu/ 5bvDwl+vEkGM/e0FN+NNAGOQvA2mqq4TuPMgBHMlFmpUACx5whl52L1DeBbb3nRI69HB uipeJF8CJmNyHAifURJh+CAKtpQVDQS13GaEesSuDvWWtpGwVqQDqz/TTYBr46IJyveA C64h8dKvpZUPAJRSgdNw6wq6Osuw0jIZ0Naf85TulXVfnYZ27MAldAxqNTOiedj2FkkE dP92PX8wjEP++JyiaR2MgjmWc1rcvTrCPiYi8VbwmVquoQrnz4YjP89lcRRunS7Kh0za hcQg== X-Gm-Message-State: APjAAAWX0oQRBnK7am9UhmSLeJeMPCKX5YtUCNoMX1VToH0OXE+lFzYv JRzdG3Wo+AAMgpQUBva/+hM= X-Received: by 2002:a63:4718:: with SMTP id u24mr23764938pga.381.1553012654464; Tue, 19 Mar 2019 09:24:14 -0700 (PDT) Received: from localhost.localdomain ([47.91.249.165]) by smtp.gmail.com with ESMTPSA id h23sm17626689pfn.68.2019.03.19.09.24.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Mar 2019 09:24:13 -0700 (PDT) From: Jeff Xie To: buytenh@wantstofly.org, kvalo@codeaurora.org Cc: davem@davemloft.net, chongguiguzi@gmail.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net:mwl8k:move spin_lock_bh to spin_lock in tasklet Date: Wed, 20 Mar 2019 00:24:05 +0800 Message-Id: <1553012645-28989-1-git-send-email-chongguiguzi@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is unnecessary to call spin_lock_bh in a tasklet. Signed-off-by: Jeff Xie --- drivers/net/wireless/marvell/mwl8k.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c index 8e4e9b6..21a86cc 100644 --- a/drivers/net/wireless/marvell/mwl8k.c +++ b/drivers/net/wireless/marvell/mwl8k.c @@ -4631,7 +4631,7 @@ static void mwl8k_tx_poll(unsigned long data) limit = 32; - spin_lock_bh(&priv->tx_lock); + spin_lock(&priv->tx_lock); for (i = 0; i < mwl8k_tx_queues(priv); i++) limit -= mwl8k_txq_reclaim(hw, i, limit, 0); @@ -4641,7 +4641,7 @@ static void mwl8k_tx_poll(unsigned long data) priv->tx_wait = NULL; } - spin_unlock_bh(&priv->tx_lock); + spin_unlock(&priv->tx_lock); if (limit) { writel(~MWL8K_A2H_INT_TX_DONE, -- 2.7.4