Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1553013040.152266.49.camel@acm.org>
Subject: Re: [PATCH v2 01/19] locking/lockdep: Change all print_*() return
 type to void
From:   Bart Van Assche <bvanassche@acm.org>
To:     Joe Perches <joe@perches.com>, Yuyang Du <duyuyang@gmail.com>,
        peterz@infradead.org, will.deacon@arm.com, mingo@kernel.org
Cc:     ming.lei@redhat.com, linux-kernel@vger.kernel.org
Date:   Tue, 19 Mar 2019 09:30:40 -0700
In-Reply-To: <494746a793619dd9b43fb152de811a6e7de77cce.camel@perches.com>
References: <20190318085733.3143-1-duyuyang@gmail.com>
         <20190318085733.3143-2-duyuyang@gmail.com>
         <494746a793619dd9b43fb152de811a6e7de77cce.camel@perches.com>
Content-Type: text/plain; charset="UTF-7"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2019-03-18 at 02:45 -0700, Joe Perches wrote:
+AD4 +AD4 -static void
+AD4 +AD4 -print+AF8-circular+AF8-lock+AF8-scenario(struct held+AF8-lock +ACo-src,
+AD4 +AD4 -			     struct held+AF8-lock +ACo-tgt,
+AD4 +AD4 -			     struct lock+AF8-list +ACo-prt)
+AD4 +AD4 +-static void print+AF8-circular+AF8-lock+AF8-scenario(struct held+AF8-lock +ACo-src,
+AD4 +AD4 +-					 struct held+AF8-lock +ACo-tgt,
+AD4 +AD4 +-					 struct lock+AF8-list +ACo-prt)
+AD4 
+AD4 trivia:
+AD4 
+AD4 This style change seems superfluous as many
+AD4 other existing functions use the previous style.

I share Joe's opinion. 

Bart.