Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1533228img; Tue, 19 Mar 2019 09:36:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqw5c86Ej/+TU++LONDXEtYoOw8Wc1FnFnchzrq37tocGzt99xmalH+4r+8OyrZhkyVFXoNb X-Received: by 2002:a62:565c:: with SMTP id k89mr2825866pfb.175.1553013412916; Tue, 19 Mar 2019 09:36:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553013412; cv=none; d=google.com; s=arc-20160816; b=Hfc5eVWDRLZFG4wC5Vo0QC3h5SQ8xIQzD7uKuMgmMbadvQlz1PlN4eC+tcglSUB4YX RIqkTSQ0u+SIcMSakFZ2QIymWEy5I6zi+JtIusfjgg9U/L5Zpzmezx9qgeOyf2J/xqrf nj1718gE8dOxyiGo/SQVcV4fyz9VbGEBLKIgwNo1F6TwvIc+nrgJdFey6FMo3drSnrra bSEioAeItcg4dSzVmhRzXfc1eGgQtuDSvVoo+zeBziObzTdWdFWTGivhHTqrHgTquhzd 8zxnCP4VXXwnaPb2XI38QEHf5aWPLc/DLfKQwdRCE3Qf+s7M6f1n3yP4cvMbhf8KkiY0 B80g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=j8iCJ0cMpwgCdtoCoT1ZKVV69uNY2z7tYXnK+yTMauY=; b=N8hmigdhhb6z8jMNuwBYnlbOlYsPrbOtCVc1zXuP0bqOBUeZ7Eus5rsDXszslx/k6m JhKEdMP99rPZJzZnWltD0VWfIbpdKDi4cCEP31xpEBCVGjAr3Jmavz93DlI4HYAFn9AR s9A+l8SqhB6ccKAya1wtDyQYtiSOpZBok//QP7TCQCZ4zFw5OOl63e0x25BOaFUGbgf2 x2wNI5oOIJB8SK7l/ANrQwo2NnZR5VghhR/pVWapzSgXAVFf9hKA7vqMjODzL661g8O5 E43Jg46Lno9I3MuRuct6VHmXA2pm38OoVT8ap7hA3EldziO+L2Zhrh5ffHtkh/VqCypt SvuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u5si11787443pgi.162.2019.03.19.09.36.37; Tue, 19 Mar 2019 09:36:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727126AbfCSQfw (ORCPT + 99 others); Tue, 19 Mar 2019 12:35:52 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:35450 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726579AbfCSQfw (ORCPT ); Tue, 19 Mar 2019 12:35:52 -0400 Received: by mail-pf1-f194.google.com with SMTP id j5so14099666pfa.2 for ; Tue, 19 Mar 2019 09:35:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=j8iCJ0cMpwgCdtoCoT1ZKVV69uNY2z7tYXnK+yTMauY=; b=OjXQagzAASdjJ4FuVeOYG6tP4n16irtq9dByXJWmR1qVFGMsDnR1ENXTCqDNSIvuod x7sSM2s+qSoC/V8qDl0l1MNb6u5Xc4IVRxbs+Tg1D8kducy9BTLwGUYI5lSzr5hn33Ch 8x2Cz/+2mAvM9jcNNA+QfbTT0yxTaWnZOEyrxK1ECm2/trZePj9a5mMuuAk06Uc2gf4Q qnjjWFtgLjeb/C6G4uFtaYOOE5THGqKfhG0qXTIysaBfSHx1to5BVdb9OwOZtf6Ge3N9 lmhRnfouWDEQYC71Btudr5Z9H84JlyEPWyo9UIGCbCjFbMam93PoZ1U17ASMUvllCD3A 6JDw== X-Gm-Message-State: APjAAAWgZDZYpI6rCrHp+6XpWTlGfRiOckXpK62QasJuJfJzmP9wHAU6 Ofslr2P6wKupJ7R9WG4z+zE= X-Received: by 2002:aa7:8384:: with SMTP id u4mr2757410pfm.190.1553013351630; Tue, 19 Mar 2019 09:35:51 -0700 (PDT) Received: from ?IPv6:2620:15c:2cd:203:5cdc:422c:7b28:ebb5? ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5]) by smtp.gmail.com with ESMTPSA id b15sm25416390pfj.167.2019.03.19.09.35.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Mar 2019 09:35:50 -0700 (PDT) Message-ID: <1553013349.65329.0.camel@acm.org> Subject: Re: [PATCH v2 07/19] locking/lockdep: Update obsolete struct field description From: Bart Van Assche To: Yuyang Du , peterz@infradead.org, will.deacon@arm.com, mingo@kernel.org Cc: ming.lei@redhat.com, linux-kernel@vger.kernel.org Date: Tue, 19 Mar 2019 09:35:49 -0700 In-Reply-To: <20190318085733.3143-8-duyuyang@gmail.com> References: <20190318085733.3143-1-duyuyang@gmail.com> <20190318085733.3143-8-duyuyang@gmail.com> Content-Type: text/plain; charset="UTF-7" X-Mailer: Evolution 3.26.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-03-18 at 16:57 +-0800, Yuyang Du wrote: +AD4 struct lock+AF8-chain +AHs +AD4 - /+ACo see BUILD+AF8-BUG+AF8-ON()s in lookup+AF8-chain+AF8-cache() +ACo-/ +AD4 +- /+ACo +AD4 +- +ACo irq+AF8-context: the same as irq+AF8-context in held+AF8-lock below +AD4 +- +ACo depth: the number of held locks in this chain +AD4 +- +ACo base: the index in chain+AF8-hlocks for this chain +AD4 +- +ACo-/ +AD4 unsigned int irq+AF8-context : 2, +AD4 depth : 6, +AD4 base : 24+ADs Have you considered to use the kernel-doc style for documenting these structure members? Thanks, Bart.