Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1542223img;
        Tue, 19 Mar 2019 09:49:56 -0700 (PDT)
X-Google-Smtp-Source: APXvYqwNTqEXPI5eMDYPS7q2RLK14inmzjfjlXqsql6askhYNRoSI+ZYz/TW0YNy1vLd46epVjdn
X-Received: by 2002:a63:ff0c:: with SMTP id k12mr2654434pgi.358.1553014196694;
        Tue, 19 Mar 2019 09:49:56 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1553014196; cv=none;
        d=google.com; s=arc-20160816;
        b=y6mZz/TaTUWVjgy6VmRkaMWvCijr3dsQSj6UHLa/FCMxdGy7vONYRzdly5PG+lKwKG
         jZ8rXyE4b7P2kYxPne+UZv9v92xxvP1Py3EtHaeHGjiCO2XarEkd51VfE9fMB5tqXoWe
         pSk+hlfnGC50Qr37D3D5wq21kXLeG4BPd+HV1faG9aTlgaVZDe9JryfctVCMuMUuGjiJ
         n2xxTcvC0L8bZ2z9dqpEsqgNVRNbjY3k1k4djEvljf97sLjAhPyqiy7nl6Fkmg3HEWzN
         XUEK4I9huaSC1pduUHhH4Mlt9amMBXkpfNCR52dqSQLdAfVI35McS+P9arPXc6FBFxn4
         lTwQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:date:cc:to:from:subject:message-id;
        bh=H9n2COm6nr/Rcp6IsHAzjRaQZOYKhoUBdXfFQIGZ27g=;
        b=WSZ0c6RI4eh38gS+kzNHJsL7cqXagLvYb2CgMS34b9XiMgSHPEyuiqIIxvSufr20MI
         vkk4P13XuHd5gx+NqBIAUgtnSayVpAZ+RZJTnTg/kHuv7vXp/aVJNRgMLN0EQVSMBfJY
         d8WYadUPJ4r8E5oLgR/c0IoQ4/J3vUE4kOUucZeiKMu9DR7BxK+zmcVBe4eiM5eZraGH
         gUN05m4IyOGbFhisOJ2y+PL2s+bHZydImmFr827SV6sAeyflXqfJgtgLrrX5/MB1I1tm
         5CYmLhYnYSD5f9t3D6BFgIq1DJyqcN3njWhGbAXpQ2XR/me+c42dN338eGjcE4jggmUk
         +uTA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id o16si12726242pgc.327.2019.03.19.09.49.41;
        Tue, 19 Mar 2019 09:49:56 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727831AbfCSQs6 (ORCPT <rfc822;yxhlfx@gmail.com> + 99 others);
        Tue, 19 Mar 2019 12:48:58 -0400
Received: from mail-pf1-f194.google.com ([209.85.210.194]:33733 "EHLO
        mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726876AbfCSQs6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 19 Mar 2019 12:48:58 -0400
Received: by mail-pf1-f194.google.com with SMTP id i19so14116761pfd.0
        for <linux-kernel@vger.kernel.org>; Tue, 19 Mar 2019 09:48:58 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=H9n2COm6nr/Rcp6IsHAzjRaQZOYKhoUBdXfFQIGZ27g=;
        b=KoGELvHQawqSd7SbsmcBNNGTjoEay6UcVTkxX+rzrBfi33XjaC1mv3U0PXXFrQeoFC
         GuJlJITUXYgd1GVpDMk/ggrbhDbcGEb0VYrh3d1ncOTghcyGcM7bIN4eT9ubrw8qz1NV
         WcuDFmalkYlRpQnPPcmDvYNxnGphFQXaomfdjRHq4dbkXYq43grGoSY0JGQJvyKHUG06
         xIzVxbTB+vlRhm6tqicDpr0RwjbrLsHC5y81HzKGLcCQ78rIsiVo9NrcEWzBDtahh5bD
         DQnZOR+88fswYfQxUHavlPai9MZPNPgXB737F+lJGIGRENXrWf0OyEobxv7VuQgdp2SJ
         g5sQ==
X-Gm-Message-State: APjAAAXj00GN4G6nDBRMIZTLxowXZzH39spQ3kNWjN3weV/BKCr3vW9J
        ahyHPVQuCGVcEzkax3QlJd0=
X-Received: by 2002:a62:1d90:: with SMTP id d138mr3006172pfd.232.1553014137991;
        Tue, 19 Mar 2019 09:48:57 -0700 (PDT)
Received: from ?IPv6:2620:15c:2cd:203:5cdc:422c:7b28:ebb5? ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5])
        by smtp.gmail.com with ESMTPSA id f3sm20329400pfn.100.2019.03.19.09.48.56
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Tue, 19 Mar 2019 09:48:57 -0700 (PDT)
Message-ID: <1553014136.65329.4.camel@acm.org>
Subject: Re: [PATCH v2 13/19] locking/lockdep: Remove unnecessary function
 pointer argument
From:   Bart Van Assche <bvanassche@acm.org>
To:     Yuyang Du <duyuyang@gmail.com>, peterz@infradead.org,
        will.deacon@arm.com, mingo@kernel.org
Cc:     ming.lei@redhat.com, linux-kernel@vger.kernel.org
Date:   Tue, 19 Mar 2019 09:48:56 -0700
In-Reply-To: <20190318085733.3143-14-duyuyang@gmail.com>
References: <20190318085733.3143-1-duyuyang@gmail.com>
         <20190318085733.3143-14-duyuyang@gmail.com>
Content-Type: text/plain; charset="UTF-7"
X-Mailer: Evolution 3.26.2-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2019-03-18 at 16:57 +-0800, Yuyang Du wrote:
+AD4 check+AF8-prev+AF8-add() always has save+AF8-trace() as an input argument, which is
+AD4 unnecessary.

I think this kind of transformation is called constant propagation. You may
want to mention that name. Anyway:

Reviewed-by: Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4