Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1553014306.65329.7.camel@acm.org>
Subject: Re: [PATCH v2 14/19] locking/lockdep: Change type of the element
 field in circular_queue
From:   Bart Van Assche <bvanassche@acm.org>
To:     Yuyang Du <duyuyang@gmail.com>, peterz@infradead.org,
        will.deacon@arm.com, mingo@kernel.org
Cc:     ming.lei@redhat.com, linux-kernel@vger.kernel.org
Date:   Tue, 19 Mar 2019 09:51:46 -0700
In-Reply-To: <20190318085733.3143-15-duyuyang@gmail.com>
References: <20190318085733.3143-1-duyuyang@gmail.com>
         <20190318085733.3143-15-duyuyang@gmail.com>
Content-Type: text/plain; charset="UTF-7"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2019-03-18 at 16:57 +-0800, Yuyang Du wrote:
+AD4 The element field is an array in struct circular+AF8-queue to keep track of locks
+AD4 in the search. Making it the same type as the locks avoids type cast.  Also
+AD4 fix a typo.

BTW, your patch does more than fixing a typo. This patch elaborates the comment
above struct circular+AF8-queue. I think the commit message should mention that.

Bart.