Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1568389img; Tue, 19 Mar 2019 10:23:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqygIzIe44Uw+cY97oNz1Kw8EzgzdlDyPXGMDCtan+CTnGJoluUFEF+tpOFX8B/m0NiUEAZS X-Received: by 2002:a62:be0b:: with SMTP id l11mr3088729pff.52.1553016236311; Tue, 19 Mar 2019 10:23:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553016236; cv=none; d=google.com; s=arc-20160816; b=R+uhVEGGwzHF/5ihnPGtGOpxo0x7K7pqpES98QTLTqJSiyaF4gYPD0AOJxZeXHLTbC 7nwahewajtvRHT1e69wJKEIZtRIKfXbN8GjFEuI525LGnXTWP1N+2wsQ5U7rUkwGLJZ5 9tH8MC5qnXOtIbjO9JyXWTwRRc7D/dCzjTotsOyCP/O/5St4uD9ccsuf0E+wIF/LJzC4 Ewepg4BOmr+YlDrlpHF+MIXQxzJtwQSRK6opRTdrOBBQCyQB3aAgQXherfcCzEFHJT9M t7O3mjlbHw+89QiO3LdFQfPbmBPEQ5DYxHA/0vCLE192bytNaYRN7LBDe4haMLAUV0sh EXLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=a7XiR+wDXrgognYXwXb8B0nOe7RqZRd0nfnoJsKowhM=; b=cj48cGlotvVDmpKft/Pn2zwz43XuBgXhytMOYtEaE83GiDlmmcBV0nTR/JEXk7eAF7 kjNFuhjPc4WQdCa6nRAKQWEOoqT0D5hQdWvga1zYp4zQdLJRcCMybB9GMCrPqIqZ2RBi MftA2E66KRUAnT6a308VwdY1KYl0phON4Lm6bjVeoARxi36eMRwQbPvhecF9lvYxSaDE PXy5P9JE6iA592qQIK0Wkd+UY6+xT5M9L1DpcUkrLoNMU4IcErlN8IDDmUPSI1cstRgD jHYR+8UfXoXKZxiSm0g5EbYM+LC6rkdCT6+svpyySGSULq5MRaw9juXy5WBQhFNH+lfv 9hGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=X2NJiHAk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 38si12075960pgn.121.2019.03.19.10.23.41; Tue, 19 Mar 2019 10:23:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=X2NJiHAk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727237AbfCSRXE (ORCPT + 99 others); Tue, 19 Mar 2019 13:23:04 -0400 Received: from mta-p8.oit.umn.edu ([134.84.196.208]:43560 "EHLO mta-p8.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726778AbfCSRXE (ORCPT ); Tue, 19 Mar 2019 13:23:04 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id 58571697 for ; Tue, 19 Mar 2019 17:23:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IypPD8jMAumi for ; Tue, 19 Mar 2019 12:23:03 -0500 (CDT) Received: from mail-it1-f198.google.com (mail-it1-f198.google.com [209.85.166.198]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id 23FE6B72 for ; Tue, 19 Mar 2019 12:23:03 -0500 (CDT) Received: by mail-it1-f198.google.com with SMTP id 9so18024231ita.8 for ; Tue, 19 Mar 2019 10:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=a7XiR+wDXrgognYXwXb8B0nOe7RqZRd0nfnoJsKowhM=; b=X2NJiHAkRAd9VBDr/wcDegqmJ89yx+uNFNPmERFicZ0w+vqEnMUGhCX4DcU+y2l7hg X9jkyV6eD4WHpBp3pl07PUDCGhkGvoFnBWLdderIakolZwmiqcL9Ms++ksFnbRYza+bt Kr3Bx+IF8zBGFrO2yKHQWUbsYxTxyb4IuzAyUjPnQ3uZDl/B48qN8fKuQzArqH60ar2o 7tj3KZKFTzyb1p7lDjjVdEpFaQ44v119AuzY7v2jF6yJ2PuUcQ8yStbnBFILihareLda xRCUb/Dm/tsgTGiAxkpkGNwABUnyaSBz1jahgz63L8GFQ6zYwdFGSyWVnDY2iYJJ51A5 Y8Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=a7XiR+wDXrgognYXwXb8B0nOe7RqZRd0nfnoJsKowhM=; b=OnxrjvxR3LdzUL6owvpEPD6CrRcshLGuZFVsCcsCGKA+JiwtdK2q7xaaRLmVvdmWAE gjZfFI+vxLWqkb+9VWqFqtEIHJwV6g0JiXv6/8XxBwxFu5YJzRY2jFOrOVN/d3G5U9PT zHaMg+ciaXOezgO8wbuJBNi8PK7rpsI5vgCApwXzPDQc6hXpjVCAtPIpUCAutUetZIY2 av/n1bCwzknNhcRQJzWxFRanfnm+zTt9ZUQ4zgoMdLEgLQa3u9OKxbjeZjMcZ3Yg2hnO CNPLim1nCG1RJSr8hfmHst+eakrW98HD9PawvMOb9ZMbCe70Dwd+9rJ62NKR7H+wc6fi /Yvg== X-Gm-Message-State: APjAAAULh+CEswVGnc35GvkRp5jVfu7keR4LxNWcU6lVGfXsJ8bSg3D2 bYVouAS95TJ74rl6TnNDgTBcUDB2yfLbcVaqznZpWy56v6+KYOehYXU15v3ZfolI7uYUU0lTY8p +3UMAOoAJljjBssGLwM8upaBhSjKe X-Received: by 2002:a6b:f419:: with SMTP id i25mr2302392iog.216.1553016182545; Tue, 19 Mar 2019 10:23:02 -0700 (PDT) X-Received: by 2002:a6b:f419:: with SMTP id i25mr2302376iog.216.1553016182374; Tue, 19 Mar 2019 10:23:02 -0700 (PDT) Received: from cs-u-syssec1.dtc.umn.edu (cs-u-syssec1.cs.umn.edu. [128.101.106.66]) by smtp.gmail.com with ESMTPSA id z63sm1580893itc.39.2019.03.19.10.23.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Mar 2019 10:23:01 -0700 (PDT) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , linux-kernel@vger.kernel.org Subject: [PATCH] thunderbolt: Fix to check return value of ida_simple_get Date: Tue, 19 Mar 2019 12:22:59 -0500 Message-Id: <20190319172259.8874-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ida_simple_get on failure can return an error. The patch ensures that the dev_set_name is set on non failure cases. Signed-off-by: Aditya Pakki --- drivers/thunderbolt/xdomain.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c index e27dd8beb94b..b1768f595259 100644 --- a/drivers/thunderbolt/xdomain.c +++ b/drivers/thunderbolt/xdomain.c @@ -772,7 +772,9 @@ static void enumerate_services(struct tb_xdomain *xd) svc->dev.bus = &tb_bus_type; svc->dev.type = &tb_service_type; svc->dev.parent = &xd->dev; - dev_set_name(&svc->dev, "%s.%d", dev_name(&xd->dev), svc->id); + if (svc->id >= 0) + dev_set_name(&svc->dev, "%s.%d", dev_name(&xd->dev), + svc->id); if (device_register(&svc->dev)) { put_device(&svc->dev); -- 2.17.1