Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1596072img; Tue, 19 Mar 2019 11:03:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqy/szZ/3U40+BUlZ5fAd1UgPRO7QatdYCTuS7tpxM9cfO9fCrRQdvNgIeiJnzOvXKRYXqUu X-Received: by 2002:aa7:864a:: with SMTP id a10mr3416742pfo.181.1553018626508; Tue, 19 Mar 2019 11:03:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553018626; cv=none; d=google.com; s=arc-20160816; b=DaupS1JFbAhwdQjeo13RZiZGCNqJK27q/+Vhl25P/JqYkpum5c9N8aX41y+A17wN0c wVpeQQ0oy+/gyiw/cjQp5gb9kVx5auzhx4bm2xvdgEiRmSVfNkzqH+P8W+1phpzNZoY3 DuntYjj6V12w/5l7xmaARVjoUz5Z5X6nsIGiD6Y/sx44T2rKvgVXajd2UXbGxmsuUImk UT1Aiu+JSw9cE46B8bwikliHynRW0/IRyBStnARQmrO76El54m8B80WF/Y5vEXEy8a82 RnRutzh/Zuu3ZKJEB862/okyhdzFvtuDaDcAWFpMvGCFFRNvXsjRf6EIPLyE9kfowEU6 K+MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=j7wBLdCJbTzs+6Fxd25WFaoQuqboFDKMyoI6KG3bXjY=; b=wHh4rlri4QYeT6qz6fCVKJHu1kCeTsPm+2A3IbkUWAvXmGAwgR/ZF/vVEistbWQR3b STa1SaVLNzLxtok8eu/1OtjUFlF+7VTCoVOYUtLN5zV92/6glQks7t8f35jvegLKeHOx HFDS6C5Yfb2z2xzTvV8syf3Y7hShR5WjaisKRsmxhPoGyoCjlQsW4uD3mKx6q4i9isFv OC6fvKKcqd7625yoglqrtGaO+uHlO543BGscKVhQlKGiHMBElzD3wzY2DSWUzCCrajvB Ru2qmAXGxO1ztuPdhFt5E/c3AgMIb5gaBuIGHgxDtKgvY3EpSiS1gNDli/KsN8H6XixC tGXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c24si12740894pls.18.2019.03.19.11.03.29; Tue, 19 Mar 2019 11:03:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727735AbfCSSCj (ORCPT + 99 others); Tue, 19 Mar 2019 14:02:39 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59726 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727237AbfCSSCi (ORCPT ); Tue, 19 Mar 2019 14:02:38 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 3CA3F3802; Tue, 19 Mar 2019 18:02:37 +0000 (UTC) Date: Tue, 19 Mar 2019 11:02:36 -0700 From: Andrew Morton To: Peter Xu Cc: linux-kernel@vger.kernel.org, Paolo Bonzini , Hugh Dickins , Luis Chamberlain , Maxime Coquelin , Maya Gokhale , Jerome Glisse , Pavel Emelyanov , Johannes Weiner , Martin Cracauer , Denis Plotnikov , linux-mm@kvack.org, Marty McFadden , Mike Kravetz , Andrea Arcangeli , Mike Rapoport , Kees Cook , Mel Gorman , "Kirill A . Shutemov" , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Dr . David Alan Gilbert" Subject: Re: [PATCH v2 1/1] userfaultfd/sysctl: add vm.unprivileged_userfaultfd Message-Id: <20190319110236.b6169d6b469a587a852c7e09@linux-foundation.org> In-Reply-To: <20190319030722.12441-2-peterx@redhat.com> References: <20190319030722.12441-1-peterx@redhat.com> <20190319030722.12441-2-peterx@redhat.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Mar 2019 11:07:22 +0800 Peter Xu wrote: > Add a global sysctl knob "vm.unprivileged_userfaultfd" to control > whether userfaultfd is allowed by unprivileged users. When this is > set to zero, only privileged users (root user, or users with the > CAP_SYS_PTRACE capability) will be able to use the userfaultfd > syscalls. Please send along a full description of why you believe Linux needs this feature, for me to add to the changelog. What is the benefit to our users? How will it be used? etcetera. As it was presented I'm seeing no justification for adding the patch!