Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 19 Mar 2019 11:01:16 -0700
From:   Benson Leung <bleung@google.com>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        linux-kernel@vger.kernel.org, Urja Rannikko <urjaman@gmail.com>,
        bleung@google.com
Subject: Re: [PATCH] platform/chrome: cros_ec_debugfs: cancel/schedule
 logging work only if supported
Message-ID: <20190319180116.GA39795@google.com>
References: <1553013156-2808-1-git-send-email-linux@roeck-us.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="EVF5PPMfhYS0aIcm"
Content-Disposition: inline
In-Reply-To: <1553013156-2808-1-git-send-email-linux@roeck-us.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--EVF5PPMfhYS0aIcm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Guenter,

On Tue, Mar 19, 2019 at 09:32:36AM -0700, Guenter Roeck wrote:
> The following traceback was reported on ASUS C201, which does not support
> console logging.
>=20
> ------------[ cut here ]------------
> WARNING: CPU: 2 PID: 361 at kernel/workqueue.c:3030 __flush_work+0x38/0x1=
54
> Modules linked in: snd_soc_hdmi_codec cros_ec_debugfs cros_ec_sysfs uvcvi=
deo dw_hdmi_cec dw_hdmi_i2s_audio videobuf2_vmalloc cfg80211 gpio_charger r=
k_crypto rfkill videobuf2_memops videobuf2_v4l2 des_generic videobuf2_commo=
n ofpart m25p80 spi_nor tpm_i2c_infineon sbs_battery mtd tpm joydev cros_ec=
_dev coreboot_table evdev mousedev ip_tables x_tables [last unloaded: brcmu=
til]
> CPU: 2 PID: 361 Comm: systemd-sleep Not tainted 5.1.0-rc1-1-ARCH+ #1
> Hardware name: Rockchip (Device Tree)
> [<c020e4b0>] (unwind_backtrace) from [<c020ac18>] (show_stack+0x10/0x14)
> [<c020ac18>] (show_stack) from [<c07a3e04>] (dump_stack+0x7c/0x9c)
> [<c07a3e04>] (dump_stack) from [<c0222748>] (__warn+0xd0/0xec)
> [<c0222748>] (__warn) from [<c022279c>] (warn_slowpath_null+0x38/0x44)
> [<c022279c>] (warn_slowpath_null) from [<c02365d0>] (__flush_work+0x38/0x=
154)
> [<c02365d0>] (__flush_work) from [<c023786c>] (__cancel_work_timer+0x114/=
0x1a4)
> [<c023786c>] (__cancel_work_timer) from [<bf33233c>] (cros_ec_debugfs_sus=
pend+0x14/0x1c [cros_ec_debugfs])
> [<bf33233c>] (cros_ec_debugfs_suspend [cros_ec_debugfs]) from [<c056a888>=
] (dpm_run_callback+0x64/0xcc)
> [<c056a888>] (dpm_run_callback) from [<c056ad2c>] (__device_suspend+0x174=
/0x3a8)
> [<c056ad2c>] (__device_suspend) from [<c056b9e0>] (dpm_suspend+0x174/0x1e=
0)
> [<c056b9e0>] (dpm_suspend) from [<c026b3e0>] (suspend_devices_and_enter+0=
x6c/0x50c)
> [<c026b3e0>] (suspend_devices_and_enter) from [<c026ba8c>] (pm_suspend+0x=
20c/0x274)
> [<c026ba8c>] (pm_suspend) from [<c026a628>] (state_store+0x54/0x88)
> [<c026a628>] (state_store) from [<c03cd2d0>] (kernfs_fop_write+0x114/0x18=
0)
> [<c03cd2d0>] (kernfs_fop_write) from [<c035d48c>] (__vfs_write+0x1c/0x154)
> [<c035d48c>] (__vfs_write) from [<c035f9e8>] (vfs_write+0xb8/0x198)
> [<c035f9e8>] (vfs_write) from [<c035fbc0>] (ksys_write+0x3c/0x74)
> [<c035fbc0>] (ksys_write) from [<c0201000>] (ret_fast_syscall+0x0/0x4c)
> Exception stack(0xe9365fa8 to 0xe9365ff0)
> 5fa0: 00000004 beef8b28 00000004 beef8b28 00000004 00000000
> 5fc0: 00000004 beef8b28 02319170 00000004 beef8b28 00000004 b6f3d900 beef=
8b74
> 5fe0: 0000006c beef8a98 b6c0adac b6c66534
> ---[ end trace f4ee5df14e8ea0ec ]---
>=20
> If console logging is not supported, the work structure is never
> initialized, resulting in the traceback. Calling cancel/schedule functions
> conditionally fixes the problem.
>=20
> While at it, also fix error handling in the probe function.
>=20
> Reported-by: Urja Rannikko <urjaman@gmail.com>
> Cc: Urja Rannikko <urjaman@gmail.com>
> Fixes: 6fce0a2cf5a05 ("mfd / platform: cros_ec: Move debugfs attributes t=
o its own driver")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>


Looks good. Applied to 5.1-fixes.=20

Thanks for the quick fix.
Benson


--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--EVF5PPMfhYS0aIcm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE6gYDF28Li+nEiKLaHwn1ewov5lgFAlyRLmwACgkQHwn1ewov
5liwQA/+O9tGU3IlmSrgD/0unyxBHeE8qvsFh0unuroAY72eKz23fSABIT3pd+u7
mE89PayJR4O8wF8GJTaB+oX3dcWueblUmjbihncv7AkP17aVchv6YfgfI71NE9ax
468+kVDYdBRKYLOAsFSODIPI7Rvrfj1uw5unaJF7wWEpJtqNCce7+h8iOSExTEcn
9ofHfBPsqSk+uvu6Bv7bYfYWQp8sYFGxYfFP/krGDIeATf9+9Pa7LmAOny391RjR
0bCvZLipNAQLExzNW1PJ6/yUoO8QFJ8Gyb0ICCGi7rxDmM+qYw7HY6a0nytFKk6S
5qk/ht+7h2M1T4MNH3ZXd3Z5eAtk5Tcw/T0/0M6R7gzcBwFSAdYfr1QZIT9UKhW0
tWX8+p2Qwfj4n6xo93IKPyoP/e+wKPG8Q9Qv7XoaQeHGmkMcqLOnEkKVURJoaMcT
Q6Jllklj2eOAw9LVV06CcGl5D43mDUh01tfMNhgtvUaFplq79lLwuX+CY9NZSRez
AtI6i/Ice1CJOmUTWNsLIr16sv0IPQqZMW+uXLxgEit8VOiarAet47njIzZ/ilbV
gfAcuxz5fwgiuhxLg9BQI1XuGIRS4xk5ayGbNJREsNyqOYv6w9WzwR/XVj+mHF7J
yRgku+1imFjymEJ99syqK5ApwIPWXzoYLN6AYqRpwEqkbsafp/c=
=plrn
-----END PGP SIGNATURE-----

--EVF5PPMfhYS0aIcm--