Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1620162img; Tue, 19 Mar 2019 11:38:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqxnaZX7M/LKkpJYlPI8alet8soDNRErwpM0kUEtjvYymXSFBBfYMYe76li38FS6mOuI6mql X-Received: by 2002:a63:4a20:: with SMTP id x32mr3192910pga.429.1553020727525; Tue, 19 Mar 2019 11:38:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553020727; cv=none; d=google.com; s=arc-20160816; b=ysIUq3dav4l6Dtog6jMDMKCHg+TePcqpayiOlBLzZvLSHka9zYm66Qjm1X8HEhC2B7 K+FJYytvuhDQf5bJbcGNq9qC6VuDcGPvEChxSneFfnfLpEUNcsF4cp2flZhkFr9HfPYx wbvNNL2Ej077E71DIlT/UQ9I1SRKMQWpngoHKB2TaSs2F9vh3JNVlmsswMymjF75aJyz Dtq2l/w0IyGkeTwlkoCh2ZbSu2tsnFMZY9J0ieh30wqj+KaZTuyMQpMJUz3tncS0iC56 jOX+S1akexQDKTTAIQIO0lcELCJ3fZLZMMsluqrLfI2k80jUJQcluMjcDfIDOxXVHcIs 8IDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=cvcsuesv40EeW/nlGhgFXZq/Ge7gh0asgjnrOwR/CAc=; b=xkpC3x6PwhX4ah+CxP7wEx3WJRjvW3JjjdRFrfXq8QHHvRKEbMjFfFkMkmnhUYG4Fu eP6DoMP8bsVWm5DTN53QwdTZ1I72XzKzaNFeok409SfXpVpOZ5QGdAfdnHnv0HgNdA7J ACh7uN7zSYH3z2/H5DEZ7ZCc4RGa6RfXDpKpcsMb0y3DneWAAhQhar5HMgp6VV/Xzv5V OEEAQwjl9NFnGCiGPcuIKJYnNz5fTyFllqrZ6ymFVOcs8eTjUtGnDvSsCpBFPcv+YSEx 8b9FoS3y3mu1aW9L59rtqV38rLMAi/hVWZK4WcJdFAKv/ADX6SC9o7Bd3uQu/V5pttmR sYSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=eK7U2MBy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y29si7132824pgk.385.2019.03.19.11.38.31; Tue, 19 Mar 2019 11:38:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=eK7U2MBy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727276AbfCSSht (ORCPT + 99 others); Tue, 19 Mar 2019 14:37:49 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:45766 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726768AbfCSSht (ORCPT ); Tue, 19 Mar 2019 14:37:49 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2JISlkG063128; Tue, 19 Mar 2019 18:37:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=cvcsuesv40EeW/nlGhgFXZq/Ge7gh0asgjnrOwR/CAc=; b=eK7U2MBysAY9l7S2YUNEig3SkGAUxzmRn7iyJTBO7EPjXLD0NMAFn25jGupHchV/vBYX ZAke5kRcZ/b9VqEwiKr8UycuFgzehbE2goag1cqu2/oMzsExA5oUE9+VBP60TjdC/Wkn AomthRbLTdnVxbnGJemMoA887i4d8KdGOAe62hy+7ZJwMzDs15hdTNjZ2C39YB+fddPa u7eHyVFZ8WO6R/8jI6aPdj09cefEtv4i7guRU/kpLMV0NhxZY80i+/rHw+tk05rXl1c+ gYjb4mA1rp/wtqQIibBiDZtR3O90YyBdzXxZ+PYdMymJCJxiOtyd4fU+V/qidivX330E cQ== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2r8rjupmb0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Mar 2019 18:37:45 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x2JIbcjt011450 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Mar 2019 18:37:39 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x2JIbc5a016302; Tue, 19 Mar 2019 18:37:38 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 19 Mar 2019 11:37:37 -0700 To: Kangjie Lu Cc: pakki001@umn.edu, Vinayak Holikatti , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] scsi: ufs: fix a missing check of devm_reset_control_get From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190315071156.21588-1-kjlu@umn.edu> Date: Tue, 19 Mar 2019 14:37:35 -0400 In-Reply-To: <20190315071156.21588-1-kjlu@umn.edu> (Kangjie Lu's message of "Fri, 15 Mar 2019 02:11:56 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9200 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=937 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903190132 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kangjie, > devm_reset_control_get could fail, so the fix checks its return value > and passes the error code upstream in case it fails. Applied to 5.2/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering