Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20190319093148.1909-1-leo.yan@linaro.org>
References: <20190319093148.1909-1-leo.yan@linaro.org>
From:   Stephen Boyd <sboyd@kernel.org>
Subject: Re: [RESEND PATCH] clk: hi3660: Mark clk_gate_ufs_subsys as critical
Cc:     Leo Yan <leo.yan@linaro.org>, stable@vger.kernel.org,
        Zhong Kaihua <zhongkaihua@huawei.com>,
        John Stultz <john.stultz@linaro.org>,
        Zhangfei Gao <zhangfei.gao@linaro.org>
To:     Leo Yan <leo.yan@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Message-ID: <155302456384.20095.11089482394019450818@swboyd.mtv.corp.google.com>
User-Agent: alot/0.8
Date:   Tue, 19 Mar 2019 12:42:43 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Leo Yan (2019-03-19 02:31:48)
> diff --git a/drivers/clk/hisilicon/clk-hi3660.c b/drivers/clk/hisilicon/c=
lk-hi3660.c
> index f40419959656..32ba80181cc6 100644
> --- a/drivers/clk/hisilicon/clk-hi3660.c
> +++ b/drivers/clk/hisilicon/clk-hi3660.c
> @@ -164,7 +164,7 @@ static const struct hisi_gate_clock hi3660_crgctrl_ga=
te_sep_clks[] =3D {
>         { HI3660_CLK_GATE_ISP_SNCLK2, "clk_gate_isp_snclk2",
>           "clk_isp_snclk_mux", CLK_SET_RATE_PARENT, 0x50, 18, 0, },
>         { HI3660_CLK_GATE_UFS_SUBSYS, "clk_gate_ufs_subsys", "clk_div_sys=
bus",
> -         CLK_SET_RATE_PARENT, 0x50, 21, 0, },
> +         CLK_SET_RATE_PARENT|CLK_IS_CRITICAL, 0x50, 21, 0, },

Nitpick: Please add space around | and also comment in the code why this
is a critical clk.

>         { HI3660_PCLK_GATE_DSI0, "pclk_gate_dsi0", "clk_div_cfgbus",
>           CLK_SET_RATE_PARENT, 0x50, 28, 0, },
>         { HI3660_PCLK_GATE_DSI1, "pclk_gate_dsi1", "clk_div_cfgbus",