Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp5680img; Tue, 19 Mar 2019 13:01:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqztCqtJ3qdF80TDpSWN1c3hRbzeUp23WOO+4raW5UJ+TGOkVc4Q6wHKbyeWUxl7iErLoxAI X-Received: by 2002:aa7:8102:: with SMTP id b2mr3671686pfi.69.1553025663641; Tue, 19 Mar 2019 13:01:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553025663; cv=none; d=google.com; s=arc-20160816; b=c2r+d7D+fRVusRPhbnRYaq3GtAggLAB5LpTAKMf/xRDE/v0HI2TZUqBgl7tnnPxVMh xhXGq5gjuYbGCZYW5qOrRKzqYheqN5ukobzTm24+MeXJEQeAiaj1du3ZnYXJ5CGUWGY8 5z3cqX1xVXSis99tCKeqYR/U9ZoKwDSftGnW3xa6kbVh8CUg3EhnnjJNSMP3M4PuQ4oy LEYozPI0mvQgrsgMpAp3UXEEqoVDRL9OaBIeZrwQPtrprBWy5ZrP7mwyv/ddgMruq/9q SlGN0Moa8RzDDuUelb+TZY/Pct3W17fZpLPxfed71XRV5f86uVe1stRhphWg23JmiQx7 tI7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=KOwOkhbz8WmBoAiT/wnLZx0PFhrFTU6iLPHTKe2BIzw=; b=Z4IebqStTQ+58Sgox2Asr0n0sXg+CLvuorEpn1KfVRt1U3/zeMm/LaJ5ZRAKrm6T8C 2eQgje/cRsFvfdhvK1PMejRD970J3C0cxnpbu9hcfeEOoWB9L+K9KrtJrhBbBF0IlhgC DYK7VsYz4d2GeHh4TB3O4DR2k/o8N6ldAh6Loa0GH3vtKlhxRzoC7pfGT+SWLLFPtYrP fms0M/infKGTZ1vawSzO7fP73jtGMVIaQ+nCJ9MJkDwN4s/nLF4s0YV8NIXIZ4oabwhY qGq2FsVjcvkDP51Izu1YMIsLAXqOoOZ6jE6eix/62cBBwBUdotShp1lVh2sX6on89MxK NgWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l127si12850685pfl.2.2019.03.19.13.00.42; Tue, 19 Mar 2019 13:01:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727192AbfCST7u (ORCPT + 99 others); Tue, 19 Mar 2019 15:59:50 -0400 Received: from mga18.intel.com ([134.134.136.126]:17220 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726925AbfCST7u (ORCPT ); Tue, 19 Mar 2019 15:59:50 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2019 12:59:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,245,1549958400"; d="scan'208";a="330084538" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by fmsmga005.fm.intel.com with ESMTP; 19 Mar 2019 12:59:48 -0700 Date: Tue, 19 Mar 2019 14:00:44 -0600 From: Keith Busch To: Alexandru Gagniuc Cc: bhelgaas@google.com, austin_bolen@dell.com, alex_gagniuc@dellteam.com, keith.busch@intel.com, Shyam_Iyer@Dell.com, lukas@wunner.de, okaya@kernel.org, torvalds@linux-foundation.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI/LINK: bw_notification: Do not leave interrupt handler NULL Message-ID: <20190319200044.GE24176@localhost.localdomain> References: <20190319011214.7847-1-mr.nuke.me@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190319011214.7847-1-mr.nuke.me@gmail.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 18, 2019 at 08:12:04PM -0500, Alexandru Gagniuc wrote: > I was able to test this on edge-triggered interrupts. None of my > machines have PCIe ports that use level-triggered interrupts. This > might not be too straightforward to test without a hardware yanker, > but if there's a way to force a specific interrupt to be level > triggered, I could do the testing on my end. Spec says INTx emulation is required, so I think it ought to be possible to force them to level-triggered if you disable MSI. The kernel parameter 'pci=nomsi' can force everything to INTx.