Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp22734img; Tue, 19 Mar 2019 14:39:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqy11msfvxOsZIpTLn21IzCms+mp/PBcE9mt+q/qRuIHfcig+HmosXK+54CSBoihtGjENZ3y X-Received: by 2002:a65:5c46:: with SMTP id v6mr3859840pgr.309.1553031560733; Tue, 19 Mar 2019 14:39:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553031560; cv=none; d=google.com; s=arc-20160816; b=pNNkojIvAdtA0OinqAlCKumXthdLYfW2d2vkwnriCfkzyXx0Nb4xtwGkGBDjmAsH5O msc95NNhzZgVE4h+yq6D5A43S+7aogtigZJAXz2QFAOlSswYZmR/SkbtPA7/JtU/oJ39 tjKsokHDU8RwWjh6qgVEer4Z9pSkqQ7rjdp11TaoUs+ETsJTrtGGPHL++uTcTBuq93Ae duO+0dBhnsHNCCX1Ca1QnfX/Kt2oNiRDPfCACteKcqbtLK4jeBmgKghiY3CK6BeltQq+ DgKveynZ0TSGLs76/5gRoHOV+9ySjdUVz0oKmbrB0bCGG44TlEpEmv6VoNkgUoAIxkNX SrGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ntTYITjxm8d6I2pdNHDJ26KgvCuXe2jf1RofKPevO6I=; b=oPYbx8Q0HkuPuATGPCGM+AAvJnMbnXnUAwOIUy7lyTZDS4f76MmK6vUva88wUJE80G tEBWDk0YK9DWLSZGM2Q1mt/7CwP97ouigTsuIla2t3rYxB5G+bI4GkhmIWkBEtSpWIW8 zHK5j9HbbRIB6JGt53V04trl4xXHlyh4oLr3jsrjdBN21EXZAw/UTyx61qfCnQFdvyz0 r/bOqljwEOxHyCPPM+Kw2Kb9f+tV8BfXvRH6Y4221fruhjiMMsJr6KY7jGzNa9bdFHV1 C6alwBVBlxYYXFOGMEfFFfN9dcJzvm+WsqbATt+v4jD9llTHZ4+2xOLH1R77Ukh94GXz 6ing== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m2si65842plt.394.2019.03.19.14.39.03; Tue, 19 Mar 2019 14:39:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726933AbfCSViZ (ORCPT + 99 others); Tue, 19 Mar 2019 17:38:25 -0400 Received: from mga03.intel.com ([134.134.136.65]:12486 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726741AbfCSViZ (ORCPT ); Tue, 19 Mar 2019 17:38:25 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2019 14:38:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,246,1549958400"; d="scan'208";a="135685856" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.137]) by fmsmga007.fm.intel.com with ESMTP; 19 Mar 2019 14:38:24 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id 10799301F16; Tue, 19 Mar 2019 14:38:24 -0700 (PDT) Date: Tue, 19 Mar 2019 14:38:24 -0700 From: Andi Kleen To: Peter Zijlstra Cc: kan.liang@linux.intel.com, acme@kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, jolsa@kernel.org, eranian@google.com, alexander.shishkin@linux.intel.com Subject: Re: [PATCH 03/22] perf/x86/intel: Support adaptive PEBSv4 Message-ID: <20190319213824.GY24002@tassilo.jf.intel.com> References: <20190318214144.4639-1-kan.liang@linux.intel.com> <20190318214144.4639-4-kan.liang@linux.intel.com> <20190319144748.GH5996@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190319144748.GH5996@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > How much work would intel_pmu_drain_pebs_icl() be? > > I'm thinking that might not be terrible. I had it in an early version of the code, but it ended up with a lot of code duplication. -Andi