Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 19 Mar 2019 14:46:48 -0700 (PDT)
Message-Id: <20190319.144648.2244362851338248970.davem@davemloft.net>
To:     arnd@arndb.de
Cc:     linux-api@vger.kernel.org, linux-arch@vger.kernel.org,
        netdev@vger.kernel.org, labbott@redhat.com, fw@deneb.enyo.de,
        pburton@wavecomp.com, deepa.kernel@gmail.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uapi: avoid namespace conflict in linux/posix_types.h
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190319165123.3967889-1-arnd@arndb.de>
References: <20190319165123.3967889-1-arnd@arndb.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 19 Mar 2019 17:51:09 +0100

> Florian Weimer points out an issue with including linux/posix_types.h
> from arbitrary other headers: if an application has defined a macro
> named 'fds_bits', it may stop compiling after a change in the kernel
> headers. Since fds_bits is a non-reserved identifier in C, that is
> considered a bug in the kernel headers.
> 
> The structure definition does not really seem to be helpful here,
> as the kernel no longer provides macros to manipulate it.
 ...
> Fixes: a623a7a1a567 ("y2038: fix socket.h header inclusion")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: David S. Miller <davem@davemloft.net>