Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp47781img; Tue, 19 Mar 2019 15:20:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqwV1LSnvW4QCrPiCH+q3u5fWeZGULxweU8j8jdkIB89xlA/YThUYdd267R/64Nm/FCIaKR4 X-Received: by 2002:a62:55c7:: with SMTP id j190mr4121819pfb.226.1553034026836; Tue, 19 Mar 2019 15:20:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553034026; cv=none; d=google.com; s=arc-20160816; b=Bdc6Y58yCyCPyDomBfWjOqlWeg+Kg8Otut1IlxyiDIxZaPbxWXuxuj5grphT3fzsKH ysnrwYf+fbFOY1NKMXzijF4yqHgCiptff5WHqom7fvRM/Nm9RdXR4rx9VO+jiLC4Z7U9 SblvSxN+8tJZJzQX8zoNszoj6nEwm83SArC293rwc1sEBK6kmEtR7Es+CWTD3KgrId5F BlZjiLMAbq2/0nMjFc5rDjkAnkpgcObJxKs2297n9JUWRFf9XjGoT5WAi7Jp7bIG9670 w4+WSlLE+kgqy/ATERc+g5zMmeTUzUeUBdoxYx5f3Y18JwM0oPmU5pWTD6yssNUC9OMe JLjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=g+jA7D3Vy7vmz9uLJ0/t0Q5MAehw4oUvD4UXxiV4BFU=; b=PlPt9WImkxx6Ntj35OYVtN1kXdEPV5xz6hKKiXf7nhJ2F5zIxt7VZOL7sH7bl40V+J OFyaKrZShqnno4J7TlZDuxYCb+rh4+g27RJ12Zua1JYuKy3h/kcbRCvZxjPJHyuaJS24 ossRcF/XdGt4fBVOHQVRtJ782YZ44yJNTYuDh++MOZ0/Zmmvu6STnXBUtZFak7uf8Z+1 qpRj/SWno4cFFFDAO8fBPoHLqvhIq7gxV3s7SG7onm3xS1Vu5klJvUhEDv08/jys6Mnc wqLptcrsUwf7VyjEpJZbdWoA1ctlKXDazypre7ctPfJyq9FluZ6V7XY1ZSvnkiNWHsAS GkQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f26si7883pge.226.2019.03.19.15.20.11; Tue, 19 Mar 2019 15:20:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727227AbfCSWTe (ORCPT + 99 others); Tue, 19 Mar 2019 18:19:34 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53568 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726851AbfCSWTe (ORCPT ); Tue, 19 Mar 2019 18:19:34 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id C3ACB3DA8; Tue, 19 Mar 2019 22:19:31 +0000 (UTC) Date: Tue, 19 Mar 2019 15:19:30 -0700 From: Andrew Morton To: ira.weiny@intel.com Cc: John Hubbard , Michal Hocko , "Kirill A. Shutemov" , Peter Zijlstra , Jason Gunthorpe , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , Martin Schwidefsky , Heiko Carstens , Rich Felker , Yoshinori Sato , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Ralf Baechle , James Hogan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, Dan Williams Subject: Re: [RESEND PATCH 0/7] Add FOLL_LONGTERM to GUP fast and use it Message-Id: <20190319151930.bab575d62fb1a33094160fe3@linux-foundation.org> In-Reply-To: <20190317183438.2057-1-ira.weiny@intel.com> References: <20190317183438.2057-1-ira.weiny@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 17 Mar 2019 11:34:31 -0700 ira.weiny@intel.com wrote: > Resending after rebasing to the latest mm tree. > > HFI1, qib, and mthca, use get_user_pages_fast() due to it performance > advantages. These pages can be held for a significant time. But > get_user_pages_fast() does not protect against mapping FS DAX pages. > > Introduce FOLL_LONGTERM and use this flag in get_user_pages_fast() which > retains the performance while also adding the FS DAX checks. XDP has also > shown interest in using this functionality.[1] > > In addition we change get_user_pages() to use the new FOLL_LONGTERM flag and > remove the specialized get_user_pages_longterm call. It would be helpful to include your response to Christoph's question (http://lkml.kernel.org/r/20190220180255.GA12020@iweiny-DESK2.sc.intel.com) in the changelog. Because if one person was wondering about this, others will likely do so. We have no record of acks or reviewed-by's. At least one was missed (http://lkml.kernel.org/r/CAOg9mSTTcD-9bCSDfC0WRYqfVrNB4TwOzL0c4+6QXi-N_Y43Vw@mail.gmail.com), but that is very very partial. This patchset is fairly DAX-centered, but Dan wasn't cc'ed! So ho hum. I'll scoop them up and shall make the above changes to the [1/n] changelog, but we still have some work to do.