Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp78226img; Tue, 19 Mar 2019 16:10:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqzpYT0f16GLzwQuyVLYNeC+uaKcztYyIWNdKSbiNJBRAY7QFJImsiNWH6B8rkRKQYz1Fcgv X-Received: by 2002:a63:e101:: with SMTP id z1mr4640641pgh.190.1553037013038; Tue, 19 Mar 2019 16:10:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553037013; cv=none; d=google.com; s=arc-20160816; b=Bj8Ox9cZCyORHzS+SQbwUzdiHN2xEvj+tdjGWs4mqRDnivifOvrY0XAILwQJZdyvbl g33BIFwISxNYO/zCzmUXIELHDlLG4VcRnkwufOlmon7AmeKLV127h7LXlThU7+E885de csdbAUOWQF/KP2b52BZuxqZKUogLTw/zRhnbQ65WN0FBMyxPLepagl1QDX6Q0Zya6uhN NPg7AYeXje2251qnEWCvvs5JE2to0Cf0c18vUdVsX9R6kZmBbCQ88tu3zMsZoslLCwFr 6H5ml5nc369aSSkZ9Vk5MBbxbandSjdOyJgiFq6NzB5gU2n7sTYE8m8TG6n5C/cRnfWy IvIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=nPEVnTiWSuhDBoRXO1SdFfzOhmBOtfMl84Dbp8QcfzI=; b=IflRl5ZggrUROGtWrsIJWFO2yK+tcpDwzHlVNy2DmEUYo15j2I7SOsCnPzZ45Hh6PM 5ExsunyZxl5dpA3EwRFhbGdNEX5Z1lM+PKOPNPQ51WL5n5TpFi2DWU4FeW6dw7tPFvAz 6jsTLpBhxVhWaP2SRyZ49UIhpuhWyV7JSZ0TJ/qHRxL7ivYmQ00oLOO2OVn24Pal9PYI 9ie1Lg40qheXxXHOogjuDfCFa3mxnWbozkvmm9pELMQiCfPWxnLmQMJ7+1ilk0nK1NAY zlSn4PE980dxLKcZYeT0l53raNvd2VL3iS9h1ypzYx1MUc9ZIaHQzSw1HvW5RtZN4kfH JeYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=rpYlLNPs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s14si92266pgs.98.2019.03.19.16.09.50; Tue, 19 Mar 2019 16:10:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=rpYlLNPs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727062AbfCSXHa (ORCPT + 99 others); Tue, 19 Mar 2019 19:07:30 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:48308 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726686AbfCSXH3 (ORCPT ); Tue, 19 Mar 2019 19:07:29 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2JMxDPi099486; Tue, 19 Mar 2019 23:07:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=nPEVnTiWSuhDBoRXO1SdFfzOhmBOtfMl84Dbp8QcfzI=; b=rpYlLNPsgjKHbE3ly+NYAh9LwTJ+wLwWzBtRBp5ugQ/hTSDaRb2jpmgh3ttjc8cmR7ID 4nOHcBJdK+0mixz1kM36tL10BSGw6ALJg6Z/MDLXXv6BFeeKWQCagWGjL9eYBCzeWkQD 6dr5jcCny15BpuPz0fFkXeGJL9LEhmoPsQ12aoTgo7wmcSb7JsMStzSVe4gfMQvQKjZX nCSmic6ttYirfmY4OPASBCnMkkRD5EPT0lw1E2aDW88JM7+ap5e9NkwkPh75V2lIZ9C4 vIL9bDYZOQEslLJT5cdHloxCfYbGyuRmUUyMYn2gYJEw6Z7X2S//33HzZ8SQ88vwf3NB ag== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2r8rjuqp65-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Mar 2019 23:07:05 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x2JN74N3014403 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Mar 2019 23:07:04 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x2JN73Pb025065; Tue, 19 Mar 2019 23:07:03 GMT Received: from dhcp-burlington7-2nd-B-east-10-152-55-162.usdhcp.oraclecorp.com (/10.152.32.65) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 19 Mar 2019 16:07:03 -0700 Subject: Re: [PATCH] xen/pv: Add PV specific legacy_pic struct to expose legacy IRQs. To: Jennifer Herbert , x86@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" References: <1553025739-92245-1-git-send-email-jennifer.herbert@citrix.com> From: Boris Ostrovsky Openpgp: preference=signencrypt Autocrypt: addr=boris.ostrovsky@oracle.com; prefer-encrypt=mutual; keydata= mQINBFH8CgsBEAC0KiOi9siOvlXatK2xX99e/J3OvApoYWjieVQ9232Eb7GzCWrItCzP8FUV PQg8rMsSd0OzIvvjbEAvaWLlbs8wa3MtVLysHY/DfqRK9Zvr/RgrsYC6ukOB7igy2PGqZd+M MDnSmVzik0sPvB6xPV7QyFsykEgpnHbvdZAUy/vyys8xgT0PVYR5hyvhyf6VIfGuvqIsvJw5 C8+P71CHI+U/IhsKrLrsiYHpAhQkw+Zvyeml6XSi5w4LXDbF+3oholKYCkPwxmGdK8MUIdkM d7iYdKqiP4W6FKQou/lC3jvOceGupEoDV9botSWEIIlKdtm6C4GfL45RD8V4B9iy24JHPlom woVWc0xBZboQguhauQqrBFooHO3roEeM1pxXjLUbDtH4t3SAI3gt4dpSyT3EvzhyNQVVIxj2 FXnIChrYxR6S0ijSqUKO0cAduenhBrpYbz9qFcB/GyxD+ZWY7OgQKHUZMWapx5bHGQ8bUZz2 SfjZwK+GETGhfkvNMf6zXbZkDq4kKB/ywaKvVPodS1Poa44+B9sxbUp1jMfFtlOJ3AYB0WDS Op3d7F2ry20CIf1Ifh0nIxkQPkTX7aX5rI92oZeu5u038dHUu/dO2EcuCjl1eDMGm5PLHDSP 0QUw5xzk1Y8MG1JQ56PtqReO33inBXG63yTIikJmUXFTw6lLJwARAQABtDNCb3JpcyBPc3Ry b3Zza3kgKFdvcmspIDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT6JAjgEEwECACIFAlH8 CgsCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEIredpCGysGyasEP/j5xApopUf4g 9Fl3UxZuBx+oduuw3JHqgbGZ2siA3EA4bKwtKq8eT7ekpApn4c0HA8TWTDtgZtLSV5IdH+9z JimBDrhLkDI3Zsx2CafL4pMJvpUavhc5mEU8myp4dWCuIylHiWG65agvUeFZYK4P33fGqoaS VGx3tsQIAr7MsQxilMfRiTEoYH0WWthhE0YVQzV6kx4wj4yLGYPPBtFqnrapKKC8yFTpgjaK jImqWhU9CSUAXdNEs/oKVR1XlkDpMCFDl88vKAuJwugnixjbPFTVPyoC7+4Bm/FnL3iwlJVE qIGQRspt09r+datFzPqSbp5Fo/9m4JSvgtPp2X2+gIGgLPWp2ft1NXHHVWP19sPgEsEJXSr9 tskM8ScxEkqAUuDs6+x/ISX8wa5Pvmo65drN+JWA8EqKOHQG6LUsUdJolFM2i4Z0k40BnFU/ kjTARjrXW94LwokVy4x+ZYgImrnKWeKac6fMfMwH2aKpCQLlVxdO4qvJkv92SzZz4538az1T m+3ekJAimou89cXwXHCFb5WqJcyjDfdQF857vTn1z4qu7udYCuuV/4xDEhslUq1+GcNDjAhB nNYPzD+SvhWEsrjuXv+fDONdJtmLUpKs4Jtak3smGGhZsqpcNv8nQzUGDQZjuCSmDqW8vn2o hWwveNeRTkxh+2x1Qb3GT46uuQINBFH8CgsBEADGC/yx5ctcLQlB9hbq7KNqCDyZNoYu1HAB Hal3MuxPfoGKObEktawQPQaSTB5vNlDxKihezLnlT/PKjcXC2R1OjSDinlu5XNGc6mnky03q yymUPyiMtWhBBftezTRxWRslPaFWlg/h/Y1iDuOcklhpr7K1h1jRPCrf1yIoxbIpDbffnuyz kuto4AahRvBU4Js4sU7f/btU+h+e0AcLVzIhTVPIz7PM+Gk2LNzZ3/on4dnEc/qd+ZZFlOQ4 KDN/hPqlwA/YJsKzAPX51L6Vv344pqTm6Z0f9M7YALB/11FO2nBB7zw7HAUYqJeHutCwxm7i BDNt0g9fhviNcJzagqJ1R7aPjtjBoYvKkbwNu5sWDpQ4idnsnck4YT6ctzN4I+6lfkU8zMzC gM2R4qqUXmxFIS4Bee+gnJi0Pc3KcBYBZsDK44FtM//5Cp9DrxRQOh19kNHBlxkmEb8kL/pw XIDcEq8MXzPBbxwHKJ3QRWRe5jPNpf8HCjnZz0XyJV0/4M1JvOua7IZftOttQ6KnM4m6WNIZ 2ydg7dBhDa6iv1oKdL7wdp/rCulVWn8R7+3cRK95SnWiJ0qKDlMbIN8oGMhHdin8cSRYdmHK kTnvSGJNlkis5a+048o0C6jI3LozQYD/W9wq7MvgChgVQw1iEOB4u/3FXDEGulRVko6xCBU4 SQARAQABiQIfBBgBAgAJBQJR/AoLAhsMAAoJEIredpCGysGyfvMQAIywR6jTqix6/fL0Ip8G jpt3uk//QNxGJE3ZkUNLX6N786vnEJvc1beCu6EwqD1ezG9fJKMl7F3SEgpYaiKEcHfoKGdh 30B3Hsq44vOoxR6zxw2B/giADjhmWTP5tWQ9548N4VhIZMYQMQCkdqaueSL+8asp8tBNP+TJ PAIIANYvJaD8xA7sYUXGTzOXDh2THWSvmEWWmzok8er/u6ZKdS1YmZkUy8cfzrll/9hiGCTj u3qcaOM6i/m4hqtvsI1cOORMVwjJF4+IkC5ZBoeRs/xW5zIBdSUoC8L+OCyj5JETWTt40+lu qoqAF/AEGsNZTrwHJYu9rbHH260C0KYCNqmxDdcROUqIzJdzDKOrDmebkEVnxVeLJBIhYZUd t3Iq9hdjpU50TA6sQ3mZxzBdfRgg+vaj2DsJqI5Xla9QGKD+xNT6v14cZuIMZzO7w0DoojM4 ByrabFsOQxGvE0w9Dch2BDSI2Xyk1zjPKxG1VNBQVx3flH37QDWpL2zlJikW29Ws86PHdthh Fm5PY8YtX576DchSP6qJC57/eAAe/9ztZdVAdesQwGb9hZHJc75B+VNm4xrh/PJO6c1THqdQ 19WVJ+7rDx3PhVncGlbAOiiiE3NOFPJ1OQYxPKtpBUukAlOTnkKE6QcA4zckFepUkfmBV1wM Jg6OxFYd01z+a+oL Message-ID: <2eb1fdec-6cc0-7f62-3d4f-adc5dba9971e@oracle.com> Date: Tue, 19 Mar 2019 19:06:49 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <1553025739-92245-1-git-send-email-jennifer.herbert@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9200 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=730 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903190159 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/19/19 4:02 PM, Jennifer Herbert wrote: > The ACPI tables doesn't always contain all IRQs for legacy devices > such as RTC. Since no PIC controller is visible for a PV linux guest, > under Xen, legacy_pic currently defaults to the null_legacy_pic - with > reports no legacy IRQs. Since the commit "rtc: cmos: Do not assume > irq 8 for rtc when there are no legacy irqs" by Hans de Goede > (commit id: a1e23a42f1bdc00e32fc4869caef12e4e6272f26), the rtc now > incorrectly decides it has no irq it can use, for some hardware. > > This patch rectifies the problem by providing a xen legacy_pic > struct, which is much like the null_legacy_pic except that it > reports NR_IRQS_LEGACY irqs. I assume this is for dom0? Could there be the same problem with PVH dom0? (and if yes then this should probably go into arch/x86/xen/enlighten.c). -boris