Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1553037915-85931-1-git-send-email-fei.yang@intel.com>
In-Reply-To: <1553037915-85931-1-git-send-email-fei.yang@intel.com>
From:   John Stultz <john.stultz@linaro.org>
Date:   Tue, 19 Mar 2019 16:41:24 -0700
Message-ID: <CALAqxLXaUAfz8n6Cpux7XBhHVHifTQhM_wnz4L3DzrmQ0GoCHg@mail.gmail.com>
Subject: Re: [PATCH] usb: gadget: f_fs: don't free buffer prematurely
To:     fei.yang@intel.com
Cc:     Felipe Balbi <balbi@kernel.org>,
        Greg KH <gregkh@linuxfoundation.org>,
        Jerry Zhang <zhangjerry@google.com>, andrzej.p@collabora.com,
        Vincent Pelletier <plr.vincent@gmail.com>,
        jingx.shen@intel.com, Linux USB List <linux-usb@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 19, 2019 at 4:25 PM <fei.yang@intel.com> wrote:
>
> From: Fei Yang <fei.yang@intel.com>
>
> The following kernel panic happens due to the io_data buffer gets deallocated
> before the async io is completed. Add a check for the case where io_data buffer
> should be deallocated by ffs_user_copy_worker.

Yay!  Perfect! I was up late last night chasing this crash, but
couldn't de-thread what the problem was.
So very happy to see this patch!

I'll test it here shortly!

thanks
-john