Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Damien Le Moal <Damien.LeMoal@wdc.com>
To:     Atish Patra <Atish.Patra@wdc.com>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>
CC:     Albert Ou <aou@eecs.berkeley.edu>, Andreas Schwab <schwab@suse.de>,
        Anup Patel <anup@brainfault.org>,
        Dmitriy Cherkasov <dmitriy@oss-tech.org>,
        Johan Hovold <johan@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Palmer Dabbelt <palmer@sifive.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Anup Patel <Anup.Patel@wdc.com>
Subject: Re: [v1 PATCH 4/4] RISC-V: Support nr_cpus command line option.
Thread-Topic: [v1 PATCH 4/4] RISC-V: Support nr_cpus command line option.
Thread-Index: AQHU3qIAiA88vIkHh0W9ePhVGAezdw==
Date:   Tue, 19 Mar 2019 23:56:32 +0000
Message-ID: <BYAPR04MB5816217E1BD06F0EB68E15A7E7400@BYAPR04MB5816.namprd04.prod.outlook.com>
References: <20190319222028.4293-1-atish.patra@wdc.com>
 <20190319222028.4293-4-atish.patra@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: cbf02de8-2a08-430b-1298-08d6acc68349
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2019 23:56:32.4289
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4294
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2019/03/20 7:20, Atish Patra wrote:=0A=
> If nr_cpus command line option is set, maximum possible cpu should be=0A=
> set to that value.=0A=
> =0A=
> Signed-off-by: Atish Patra <atish.patra@wdc.com>=0A=
> ---=0A=
>  arch/riscv/kernel/smpboot.c | 10 +++++++++-=0A=
>  1 file changed, 9 insertions(+), 1 deletion(-)=0A=
> =0A=
> diff --git a/arch/riscv/kernel/smpboot.c b/arch/riscv/kernel/smpboot.c=0A=
> index 609475c5..a8fe590c 100644=0A=
> --- a/arch/riscv/kernel/smpboot.c=0A=
> +++ b/arch/riscv/kernel/smpboot.c=0A=
> @@ -86,11 +86,19 @@ void __init setup_smp(void)=0A=
>  		}=0A=
>  =0A=
>  		cpuid_to_hartid_map(cpuid) =3D hart;=0A=
> -		set_cpu_possible(cpuid, true);=0A=
=0A=
This looks weird: the code being changed does not match what patch 3/4 did.=
=0A=
=0A=
>  		cpuid++;=0A=
>  	}=0A=
>  =0A=
>  	BUG_ON(!found_boot_cpu);=0A=
> +=0A=
> +	if (cpuid > nr_cpu_ids)=0A=
> +		pr_warn("Total number of cpus [%d] are greater than configured via nr_=
cpus [%d]\n",=0A=
=0A=
"The total number of cpus [%d] is greater than nr_cpus option value [%d]\n"=
=0A=
=0A=
> +			cpuid, nr_cpu_ids);=0A=
> +=0A=
> +	for (cpuid =3D 1; cpuid < nr_cpu_ids; cpuid++) {=0A=
> +		if (cpuid_to_hartid_map(cpuid) !=3D INVALID_HARTID)=0A=
> +			set_cpu_possible(cpuid, true);=0A=
> +	}=0A=
>  }=0A=
>  =0A=
>  int __cpu_up(unsigned int cpu, struct task_struct *tidle)=0A=
> =0A=
=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=