Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1553013397-29263-1-git-send-email-chongguiguzi@gmail.com> <20190319192242.GA3773@ziepe.ca>
In-Reply-To: <20190319192242.GA3773@ziepe.ca>
From:   =?UTF-8?B?6LCi5qyi?= <chongguiguzi@gmail.com>
Date:   Wed, 20 Mar 2019 08:49:12 +0800
Message-ID: <CAJ3e5OamBadQ7e1-hmS=rjCwTAa9LiUVJH3+nc1kRCymV5OPcQ@mail.gmail.com>
Subject: Re: [PATCH] infiniband:qplib_fp:move spin_lock_bh to spin_lock in tasklet
To:     Jason Gunthorpe <jgg@ziepe.ca>
Cc:     selvin.xavier@broadcom.com, devesh.sharma@broadcom.com,
        somnath.kotur@broadcom.com, sriharsha.basavapatna@broadcom.com,
        dledford@redhat.com, nux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

It was only called in the tasklet context.

root@jeff:~/git/linux-next# git grep -in  bnxt_qplib_service_nq
drivers/infiniband/hw/bnxt_re/qplib_fp.c:236:static void
bnxt_qplib_service_nq(unsigned long data)
drivers/infiniband/hw/bnxt_re/qplib_fp.c:390:
tasklet_init(&nq->worker, bnxt_qplib_service_nq,


  thanks.

Jason Gunthorpe <jgg@ziepe.ca> =E4=BA=8E2019=E5=B9=B43=E6=9C=8820=E6=97=A5=
=E5=91=A8=E4=B8=89 =E4=B8=8A=E5=8D=883:22=E5=86=99=E9=81=93=EF=BC=9A
>
> On Wed, Mar 20, 2019 at 12:36:37AM +0800, Jeff Xie wrote:
> > It is unnecessary to call spin_lock_bh in a tasklet.
> >
> > Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
> > ---
> >  drivers/infiniband/hw/bnxt_re/qplib_fp.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> I'm curious, how did you prove this was always in a tasklet?
>
> Jason


--=20
jeff