Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp66770img; Tue, 19 Mar 2019 18:03:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqwEkOzjAj3xD70VqJk1/Er7zBPIRL1bjftIb9Jq+SThnlmC4+mI6e0wmxQoqaD93w1hmmVl X-Received: by 2002:a17:902:5992:: with SMTP id p18mr5049051pli.231.1553043824462; Tue, 19 Mar 2019 18:03:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553043824; cv=none; d=google.com; s=arc-20160816; b=aoA20wDUj8p4jn13E31db4M+mlqiQnu2hA4YyBOr12EuqmqRGAuqQdA1IzFmawYxub VT1apRzwRfZI8Yl9zL7mqXVdLkJVK3dDQt5x48VYiCPQRWq0fC3yO7M+R2cPtrIvBHg1 1qRXmMpxWYTwDrRj5gs/iG6Ug/dcXX/UQr1OxanvZFr6+yhlMAiTP8F7MCpmYbGL6yAb cg4Wt2J33DAWIYam2bf1D1cl10v7X9i2/yxyFCC8+1hKW2j1LR9zfW7idB/iYIgUKBb+ lrpWfpgLFxfpJpzt//uvtc6y9B0EpTNQN0wVB9oGM3AbHaTi4wE+W7nAOEoKnwD/ZR0R 0Fqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=akWCauVOxfv0XkXX4s9fpZwSZm/a+jzC3N7+OsjFtJg=; b=gfhm9QU8okg4Z2wxn2zaxwHIZGJX4h5PZ8WY71x+F4GUc7XbVV15JQWg58ozMbWtzl gYrwOdpGjLKIvPs2haQSkjqbCPExb0NevGq3jThT7be6+QjmkKycvqWWXuB5eVQb0YcN 2qwllvxqjyJb7SNwekFD3Zo2Xfq+F0bWpveDrjr7DPfHVVHVVDQjdvCJXyRlX26qMoau QjWILtT6K+cLYIKOGHN6nKFWCrgYKJiwq3b3CRj2q33d8SEnRArqbCGaE1jRvLwqVDmB w65IkvAiVOXbRYYQVE61mQcyLSHpoZn5UqNhja+1X0otKUMAN1gFnE4ayiWLfY8cU2bE CYYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=iki.fi Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h11si486466plb.38.2019.03.19.18.03.29; Tue, 19 Mar 2019 18:03:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=iki.fi Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727414AbfCTBBx (ORCPT + 99 others); Tue, 19 Mar 2019 21:01:53 -0400 Received: from emh04.mail.saunalahti.fi ([62.142.5.110]:33536 "EHLO emh04.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727030AbfCTBBx (ORCPT ); Tue, 19 Mar 2019 21:01:53 -0400 Received: from darkstar.musicnaut.iki.fi (85-76-21-58-nat.elisa-mobile.fi [85.76.21.58]) by emh04.mail.saunalahti.fi (Postfix) with ESMTP id B350430053; Wed, 20 Mar 2019 03:01:50 +0200 (EET) Date: Wed, 20 Mar 2019 03:01:50 +0200 From: Aaro Koskinen To: Janusz Krzysztofik Cc: Tony Lindgren , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] ARM: OMAP1: ams-delta: Fix broken GPIO ID allocation Message-ID: <20190320010150.GA7872@darkstar.musicnaut.iki.fi> References: <20190319201952.1309-1-jmkrzyszt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190319201952.1309-1-jmkrzyszt@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 19, 2019 at 09:19:52PM +0100, Janusz Krzysztofik wrote: > In order to request dynamic allocationn of GPIO IDs, a negative number > should be passed as a base GPIO ID via platform data. Unfortuntely, > commit 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global > GPIO numbers") didn't follow that rule while switching to dynamically > allocated GPIO IDs for Amstrad Delta latches, making their IDs > overlapping with those already assigned to OMAP GPIO devices. Fix it. > > Fixes: 771e53c4d1a1 ("ARM: OMAP1: ams-delta: Drop board specific global GPIO numbers") > Signed-off-by: Janusz Krzysztofik > Cc: stable@vger.kernel.org Acked-by: Aaro Koskinen A.