Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp75656img; Tue, 19 Mar 2019 18:16:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqyPQYAxhr+ySwBszkCeCfooKbBl58HzDGm4OmxHccPFHYloclLRS8GZOV8p8W7J6MyfV6Rj X-Received: by 2002:a17:902:5a5:: with SMTP id f34mr5082406plf.35.1553044568955; Tue, 19 Mar 2019 18:16:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553044568; cv=none; d=google.com; s=arc-20160816; b=EDWK97tC1JxSjgL4dhADWymvrmrUxL1O/qWmECh0wCMploXYaRA64KNw7Cc/o8bU0C x7h0RfrG7Ki51RR+BEqEe4xzdDk0POapv0Gj2gkTIqzlpk2tqNJBv8TvvtNo6YDv682w /gO/QpP2ZoC2J7DWxCSV97YYtI4xPbJKoEWUNqGx69piVRHiv0t7oHIJMAGcoZSVzjZ6 gy+KoYUP2CCDP4YGt2lvGAE2Pp+o+MT0YTmnkzfPqagKuIgTR99EVP8PkiFD6pwCxqcw 8rDtH+kYIvn+zy7GY5nrxJSey5Gs+q7SqlEuaCRLAT6HLTYdkIZLvKNM8se9hV9/9G4S Wcgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=ECbyCNrL6POmMsnKOC7bnI3ZWNUdHYm5lLii4apClDQ=; b=RSu2CKnbBOW2QGgV3MlNeOdP8fFq9UgqpV0VuxwqHKXuT4Q5VGVEcxfLYiTDx/EeLM phPOlw5lYSfrU/fvlfh+e6EvDg9+ae3FKIOBt2OkWmB8/lEDZDuGCYorbduxQoQ9YfGL i1nTQ5176uKdOlpwPgxKayMqw6A2ssdPnYQjaV0EncSYjGxxI1BXUMhUrZITkQlqpgoZ K292N/w40i844jcq7g9Z5LRL+i4hnBh1ceDDA6JYsj9miQUT745DHxllx6nr+yHkox5p cJLoTM0+3M73EkYpY2fdQrYVhI0XvXg/8WaHAC9mBrwPhgk5j5E5XUJoKKyhqchjhCUg p4BA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="Pl5M/KSg"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s61si404338plb.305.2019.03.19.18.15.53; Tue, 19 Mar 2019 18:16:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="Pl5M/KSg"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727270AbfCTBPT (ORCPT + 99 others); Tue, 19 Mar 2019 21:15:19 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:45557 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726896AbfCTBPS (ORCPT ); Tue, 19 Mar 2019 21:15:18 -0400 Received: by mail-pg1-f193.google.com with SMTP id y3so437625pgk.12 for ; Tue, 19 Mar 2019 18:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=ECbyCNrL6POmMsnKOC7bnI3ZWNUdHYm5lLii4apClDQ=; b=Pl5M/KSgSIiqLFbRFRJNsQDB9iKle66fx9LX4ByieGMWC8SQBtyP2qVxGhltYS52eu Cu4JrGQBrPZ21Ba3a0BCPjvBHeuk8s0ihIkCsOiR1vweZEtF8v0RcJ3OGwZOuqCvdkfc 8aUUsqwVl+eFU87Yt2inqjPTSGmqQv8Bvx6yFstigacWwF/9OzXquTDbu1KqUt7XTW1U +eUa/VfxDch+o44zrnfnoOPOJObGYm0s/0ZoAIboXUW84pMFAAeFOJAPXMoxqxf5+fWZ TfpLFNCnlqjCpiuxwrB+X0Y3mv6zHqa1bocwXzC2seg7CacojwvvykGFT7Z6oJkXzOgu xwjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=ECbyCNrL6POmMsnKOC7bnI3ZWNUdHYm5lLii4apClDQ=; b=s55AS8P+Ctjo1lAcJl/JdU56vV3CX/UUB2Mc5iNHlN4Tt/wHkkMhL+rafPsc2JWuop b4eiJ+Jxpbo7sQgd4z031qdnYdLYcg8QHSH5pQM6xEEKpImYjYPNrRFnDNBCLYFCXs4X PqikjeNhTXh3FTtCMRBP//K1tT4fLKDE17f6HblkeqviwEDEV1azlKAGiEKW2lsHTBLt +UMV9+07TucT51OGELdnBiWA0jfKIS1UNxfJgbYBYSRRfK8LG59d12q4dVxCfxMYjLaV Zs+8QriU4z7qVe2mK698rFPqjQqjWg7lLMecwfmwHG1u409eg1MgVXG/G6B9D0TGa6zK EjrQ== X-Gm-Message-State: APjAAAWDtEQAI/mWOWX5kmOqZwQxGhSu0fHnY214qFAAaRgvXRkFebco bl6Lslk4ilAj/PYOkZyzFOVLiw== X-Received: by 2002:a17:902:127:: with SMTP id 36mr5139769plb.268.1553044517257; Tue, 19 Mar 2019 18:15:17 -0700 (PDT) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id h65sm253003pgc.93.2019.03.19.18.15.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Mar 2019 18:15:16 -0700 (PDT) Date: Tue, 19 Mar 2019 18:15:16 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Liu Xiang cc: cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, liuxiang_1999@126.com Subject: Re: [PATCH] slub: remove useless kmem_cache_debug() before remove_full() In-Reply-To: <1552577313-2830-1-git-send-email-liu.xiang6@zte.com.cn> Message-ID: References: <1552577313-2830-1-git-send-email-liu.xiang6@zte.com.cn> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Mar 2019, Liu Xiang wrote: > When CONFIG_SLUB_DEBUG is not enabled, remove_full() is empty. > While CONFIG_SLUB_DEBUG is enabled, remove_full() can check > s->flags by itself. So kmem_cache_debug() is useless and > can be removed. > > Signed-off-by: Liu Xiang Acked-by: David Rientjes