Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190318085733.3143-1-duyuyang@gmail.com> <20190318085733.3143-16-duyuyang@gmail.com>
 <1553014484.65329.10.camel@acm.org>
In-Reply-To: <1553014484.65329.10.camel@acm.org>
From:   Yuyang Du <duyuyang@gmail.com>
Date:   Wed, 20 Mar 2019 10:30:50 +0800
Message-ID: <CAHttsravNVDC882277Vwqif3oicHUnixj7NuTjNE2AL0V5cpwA@mail.gmail.com>
Subject: Re: [PATCH v2 15/19] locking/lockdep: Remove __cq_empty()
To:     Bart Van Assche <bvanassche@acm.org>
Cc:     peterz@infradead.org, will.deacon@arm.com, mingo@kernel.org,
        ming.lei@redhat.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks for review.

On Wed, 20 Mar 2019 at 00:54, Bart Van Assche <bvanassche@acm.org> wrote:
>
> This is the most important change in this patch. Using the title "Remove __cq_empty()"
> for this patch is misleading because the above patch does something else, namely changing
> the return type of __cq_dequeue() from int into a pointer. Should this patch perhaps be
> split or should the __cq_empty() removal be left out from this patch?

I actually hesitated whether _cq_full() should be inlined as well.
Having said that, let me keep both of them and just change the return
type of __cq_dequeue().

Thanks,
Yuyang