Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp222504img; Tue, 19 Mar 2019 22:36:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqwaCdr7Xctg8YaEth9pPAJabF8Z0nn0ss1oXHp6bTQ3KAoBlEKNZ9ZBgtj4RIfHPQoa13g9 X-Received: by 2002:a63:5d14:: with SMTP id r20mr5621597pgb.351.1553060196334; Tue, 19 Mar 2019 22:36:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553060196; cv=none; d=google.com; s=arc-20160816; b=QSjf3TVkvAwzseHqaMHG7Xrgn91vZDrehQXkWoCN/qZ91aIsQVwvZLGKv3+9sD3PGT 64tqOBdf2cT0aFkSBVXAzFFOfY2SRXEWjjfcRk1PR6f7BYO0peluBqMuqFdYI/SW0ei9 dvxx/VWrdTNvrsFrtx1yVtCFM76Xm6yh1tMM49xdEz/q6Ne8UT9T/BINKJIJDepcTLy0 OtUcOQp0EbbRkPlbG7CZVoSmkNowsRsJcN2dFtulxa+qMI2Nw/kwcoHsmzKRG4RA+UVt ixYErQxYR8AFqr95ErlEHCOtHMx4e4gyYa5wju/T5Rfv1dwg+5uh1luWr01ra8uNuK1c hOIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:date:subject:cc:to:from; bh=9mFLYGOB3GE6p6fF9jbILMCj3NSaM0pjzfexw90HyZI=; b=MSVRz95SRxPBLKVEYXiao8sG1yTfKkC3/ocOaYVW8aXH55j/vl4oGQUaAJDX8yQthr iiicPz2Wz5hTeKltCUt/3h23iszfw+2JwL4Pzmw+BMfXd5Rdz9PfwVG/nLAwTvzPJHMQ jtUs+vZmwWbi6LWOkaOxt+oAFwdxuSmakERBP06kT1HjxrsOrrfwjNcQ8+wxpqmygBdE FJPySSqwI4EAyA01mwE3z0w1qGrRxY1Fl5AK0ikM/K8TDpGrp6v9nbkfxap5tQhdz8PB eAGRHY44jMDFOGhE3XzaBXNdYy9lAfP1T4mZiUwjahjn490MU35BFL7i4FSdLQ4LXf9o IV9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2si834173pgc.146.2019.03.19.22.36.21; Tue, 19 Mar 2019 22:36:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727603AbfCTFfi (ORCPT + 99 others); Wed, 20 Mar 2019 01:35:38 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:48742 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbfCTFfb (ORCPT ); Wed, 20 Mar 2019 01:35:31 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2K5YkJm095901 for ; Wed, 20 Mar 2019 01:35:30 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2rbbvnrfh6-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 20 Mar 2019 01:35:29 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 20 Mar 2019 05:35:21 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 20 Mar 2019 05:35:18 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x2K5ZN0Y49873120 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Mar 2019 05:35:23 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6386D11C064; Wed, 20 Mar 2019 05:35:23 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1DA1111C058; Wed, 20 Mar 2019 05:35:23 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 20 Mar 2019 05:35:23 +0000 (GMT) Received: from adsilva.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 12C80A0321; Wed, 20 Mar 2019 16:35:22 +1100 (AEDT) From: "Alastair D'Silva" To: alastair@d-silva.org Cc: Greg Kurz , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/5] ocxl: read_pasid never returns an error, so make it void Date: Wed, 20 Mar 2019 16:34:46 +1100 X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190320053448.2098-1-alastair@au1.ibm.com> References: <20190313040702.14276-1-alastair@au1.ibm.com> <20190320053448.2098-1-alastair@au1.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19032005-0020-0000-0000-00000325693E X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19032005-0021-0000-0000-000021778603 Message-Id: <20190320053448.2098-4-alastair@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-20_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=771 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903200048 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alastair D'Silva No need for a return value in read_pasid as it only returns 0. Signed-off-by: Alastair D'Silva Reviewed-by: Greg Kurz --- drivers/misc/ocxl/config.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c index 0ee7856b033d..026ac2ac4f9c 100644 --- a/drivers/misc/ocxl/config.c +++ b/drivers/misc/ocxl/config.c @@ -68,7 +68,7 @@ static int find_dvsec_afu_ctrl(struct pci_dev *dev, u8 afu_idx) return 0; } -static int read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn) +static void read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn) { u16 val; int pos; @@ -89,7 +89,6 @@ static int read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn) out: dev_dbg(&dev->dev, "PASID capability:\n"); dev_dbg(&dev->dev, " Max PASID log = %d\n", fn->max_pasid_log); - return 0; } static int read_dvsec_tl(struct pci_dev *dev, struct ocxl_fn_config *fn) @@ -205,11 +204,7 @@ int ocxl_config_read_function(struct pci_dev *dev, struct ocxl_fn_config *fn) { int rc; - rc = read_pasid(dev, fn); - if (rc) { - dev_err(&dev->dev, "Invalid PASID configuration: %d\n", rc); - return -ENODEV; - } + read_pasid(dev, fn); rc = read_dvsec_tl(dev, fn); if (rc) { -- 2.20.1