Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1553012645-28989-1-git-send-email-chongguiguzi@gmail.com>
In-Reply-To: <1553012645-28989-1-git-send-email-chongguiguzi@gmail.com>
From:   Menion <menion@gmail.com>
Date:   Wed, 20 Mar 2019 08:08:40 +0100
Message-ID: <CAJVZm6dUfAB8Q5CDCpiZhwAJcRiL=N8d3Aa-wxQx3_2ybzZROg@mail.gmail.com>
Subject: Re: [PATCH] net:mwl8k:move spin_lock_bh to spin_lock in tasklet
To:     Jeff Xie <chongguiguzi@gmail.com>
Cc:     buytenh@wantstofly.org, kvalo@codeaurora.org, davem@davemloft.net,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Is it possible that this solves this long standing issue? :
https://www.spinics.net/lists/linux-wireless/msg151171.html
Bye

Il giorno mar 19 mar 2019 alle ore 17:25 Jeff Xie
<chongguiguzi@gmail.com> ha scritto:
>
> It is unnecessary to call spin_lock_bh in a tasklet.
>
> Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
> ---
>  drivers/net/wireless/marvell/mwl8k.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c
> index 8e4e9b6..21a86cc 100644
> --- a/drivers/net/wireless/marvell/mwl8k.c
> +++ b/drivers/net/wireless/marvell/mwl8k.c
> @@ -4631,7 +4631,7 @@ static void mwl8k_tx_poll(unsigned long data)
>
>         limit = 32;
>
> -       spin_lock_bh(&priv->tx_lock);
> +       spin_lock(&priv->tx_lock);
>
>         for (i = 0; i < mwl8k_tx_queues(priv); i++)
>                 limit -= mwl8k_txq_reclaim(hw, i, limit, 0);
> @@ -4641,7 +4641,7 @@ static void mwl8k_tx_poll(unsigned long data)
>                 priv->tx_wait = NULL;
>         }
>
> -       spin_unlock_bh(&priv->tx_lock);
> +       spin_unlock(&priv->tx_lock);
>
>         if (limit) {
>                 writel(~MWL8K_A2H_INT_TX_DONE,
> --
> 2.7.4
>