Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp293138img; Wed, 20 Mar 2019 00:24:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqyWj7fh1+2lRV5RGmS8l3P6gR/08xlyFo/DVkUVD4IBp0p/eK3B6TYwLfysoHtZD7tNksAu X-Received: by 2002:a17:902:b217:: with SMTP id t23mr6510472plr.184.1553066682698; Wed, 20 Mar 2019 00:24:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553066682; cv=none; d=google.com; s=arc-20160816; b=oD4UJmoFO3q+0n3J0XCmVkteo8UzNH/hrPz69QG7eVIryXDCjPTLbWu7swTYfhTEC6 j6URa3szN6VduWkKFx3iZGsPVq2YJL0K6nOin8jKgSzpdZR/vLX9QX0jEcOaqJvk69Rc j47QzMTX8DbgInr6ph6SUyckD79rDuzrlF9OiT2sKu5CTi/9fnRf6TiNq/TJ9jDnGNiR v+uAGLIDPj8fc6Zb6jZcPtmkpLPjI08okPxrq7U7im4JZ/D1gpV06kdMF9Nwkx1omSD8 Q9gHAX39W56Z7hrn+sodiSshUhwNuse6ZtpeifCgLWbfwzDS1j/ty/4G/esBQ0uY278A TAHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=JEQryH39BxNUa3ntL96QV0C7dXu5VzANy5k0RxbVZiQ=; b=rhzWTwjwj28HN9u+1B0QdVAxd7cIHXFZzj3NGo5TRfPG4a7+0RzJfvYO8hTSrFnNaF b0gQ6hPQJB+jBeNgHqPI3ZQ19R/gR/WzLd6JiNfMPpsaVnrs3yoiu66hfFlbwp7U6Y4+ VgqMLN6w3BoyvJFdNAFsgp+SfUNjmxBciTbe6OLZcj2LK1QMnLA3PMJ5nT1OHGj3LkB+ BLfZYFyFnWvxwDr1k1g11jGKl6zI1gk4SWhkfNvDgkpG9j0oz/myMlNbeF9euoBY4i8H XgCr9Yv8ubFjYTVLW4uwStjEb50ftcs1broUwJmEVHENZbr0lCToAtBsl74J3N/BayiB ul6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=u8v3BRsv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y24si1240636plp.98.2019.03.20.00.24.27; Wed, 20 Mar 2019 00:24:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=u8v3BRsv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727246AbfCTHXu (ORCPT + 99 others); Wed, 20 Mar 2019 03:23:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:53602 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbfCTHXu (ORCPT ); Wed, 20 Mar 2019 03:23:50 -0400 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E4F521841; Wed, 20 Mar 2019 07:23:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553066629; bh=DStMdlvTwBeCuUOdxfhcXb+D6wDT2kxMz4VsHLYkZSM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u8v3BRsvmSv5jBsDcPZLoM8KdpOGJvsoREP20ndnqyLZ0vhxfjQgu2gboYQOl3sKY 8hQc3219ndOphqBTw+kBDJb/wMsyC/VjGaTDWtEj1s1+xt/BHw6CCE1IOBLlysvAu1 4ojuXqPhaHB0JPKD24EQ5erbL4a9efcr169sEkx8= Date: Wed, 20 Mar 2019 08:23:47 +0100 From: Greg Kroah-Hartman To: Aditya Pakki Cc: kjlu@umn.edu, Nathan Chancellor , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtlwifi: Fix potential NULL pointer dereference of kzalloc Message-ID: <20190320072347.GA2647@kroah.com> References: <20190319201509.16252-1-pakki001@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190319201509.16252-1-pakki001@umn.edu> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 19, 2019 at 03:15:08PM -0500, Aditya Pakki wrote: > phydm.internal is allocated using kzalloc which is used multiple > times without a check for NULL pointer. This patch avoids such a > scenario. > > -- > v1: Patch collision with different things, fix as per Greg > Signed-off-by: Aditya Pakki signed-off-by has to be above the -- line. Please fix. thanks, greg k-h