Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp293458img; Wed, 20 Mar 2019 00:25:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqzm+4mo41AGLyIPh7e1/aYarVqWjHlXpm3mYENLZ487lX9nbw81PzIdr9TbyzkAO2lqB3qx X-Received: by 2002:aa7:8459:: with SMTP id r25mr6799042pfn.65.1553066714051; Wed, 20 Mar 2019 00:25:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553066714; cv=none; d=google.com; s=arc-20160816; b=TEM8eHCXKLTYPF99EvM+H6NORZBWvAb/E6Q89ov8gxRbPkHTpROY5rAQYZBPU5fOX3 ry6CxPuevxAQzI710mQGX/ukozUEM2hZwo0rn0KdFNblCMHedF/I9U7P42Jwejf/x7bL vZET4kPkHqv7gBt4r5EUJ6vFzXsJaELVbmX12VByUhYVPMbR9uofbtoSUHVMBX+xyvOz H5UXQk3lNOPI6QQEEzAm2fYn+p1DQLFHfj5q65f9phgQgrK8c0fC+XGUS8g9u2UZff1a X+ClLxmJqs6/h4yh1XfcDA51mp8uD15y90fhFgLbSftqnwimCSGSOmLZ3VIiM4vSk13a UxMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=3PFafo5RVXLkM3R7R1WNkw5v+FXqKW0nU2fKq/jFc0o=; b=L7lpwR++ZuOdEdNMWBlnTdgXstgEAtqqz/KNxq2fk+JdXDl4e/Hb4PCln0sonN7abX vGGdM9R6hry37fmR40b9JLbC4Y0K8LlBErOtiU9Pj0q1HInSxutm5tFOhVMSWCSpPl2G 1YWh4UyXVAtKdp48iT4qtdkcWmV5+4GGHqFKkuaPtqgsiZJvT9+QgCEqLODpLBWaU/k2 Y6vv/TEOemxnTl23oHxgCDBu8tygFhaYJ4nuUxqElAL0mvzfmpV8M/duKXz3nsmAd3Gz xKlMU179ym92DHJWoksGwA7pFu8Yyjixt+Wdfiusdjva/XVW+TvLLsHoVldspTR8PxMz da9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=haE2xZRn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c23si1096372pgj.27.2019.03.20.00.24.58; Wed, 20 Mar 2019 00:25:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=haE2xZRn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727439AbfCTHYA (ORCPT + 99 others); Wed, 20 Mar 2019 03:24:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:53688 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbfCTHYA (ORCPT ); Wed, 20 Mar 2019 03:24:00 -0400 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 63F4221841; Wed, 20 Mar 2019 07:23:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553066639; bh=G/jeCtT9UUfIsnuMXfzBSlN4wjaLwUtIiit1FWBUprU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=haE2xZRnd8L02Q2xPbNFYZeIOFjE10c60kxjEBtajYRU9GuW+tuZJB6vLR0mWJRR7 RXTv6UKbsqOSJoUmBxOJqExiLyCMenoAlzC2HybwEhq75ngfz2WhE8J7QMVUk3/peE qF7xY05cWfianI4PF1RN9uNBV3VXZSWi2w1+1u94= Date: Wed, 20 Mar 2019 08:23:57 +0100 From: Greg Kroah-Hartman To: Aditya Pakki Cc: devel@driverdev.osuosl.org, kjlu@umn.edu, linux-kernel@vger.kernel.org, Sabin Mihai Rapan , Nathan Chancellor Subject: Re: [PATCH v2] staging: rtlwifi: rtl8822b: fix to avoid NULL pointer dereference Message-ID: <20190320072357.GB2647@kroah.com> References: <20190319202127.16692-1-pakki001@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190319202127.16692-1-pakki001@umn.edu> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 19, 2019 at 03:21:25PM -0500, Aditya Pakki wrote: > skb allocated via dev_alloc_skb can fail and return a NULL pointer. > This patch avoids such a scenario and returns, consistent with other > invocations. > > --- > v1: Patch collision with rtl_phydm.c, fix as per Greg > Signed-off-by: Aditya Pakki Same here, has to be above.