Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp294040img; Wed, 20 Mar 2019 00:26:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqzoHDjoCFnLCknKQXvkD/IOLZ7mfJMWjBFaoJVo2+tNPECJV6O8fgFRjS3sCK4jLKXkvqdc X-Received: by 2002:a17:902:784c:: with SMTP id e12mr6901029pln.117.1553066773195; Wed, 20 Mar 2019 00:26:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553066773; cv=none; d=google.com; s=arc-20160816; b=aOHWUIG2nNkrT4UOWRGioWgeH05Q0csIrEYhwxZTPsZUCz7HHVrOAZEO4BYX1y1lCZ SegLguCMkDnUhIVD4qPYhuYRD34CoZGEKQlmI5iVTauz6sa1r7BGkKVsjxpNoZG3cOkK MLQSiV4VLrjfRkrOy60x4DMJhX0Wiufq3MKyjFrAPm+GzcA5PSebtwTPtaIY3wD3RHW1 MKA0QqGK/ClfaFEcNgvBM/TutKFVYvtaDEjeHfg4WnGSR/rP0xnGDnTElAbdx2GbKN4O 4PGpnns6LBvokhaeqsIkSotlZhaOIg+QnPrNUlDt8VqsdlhFShdD84z1M9Al/RwPMY+i +ygA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=hp2S7NzwxFEMbgnixPhVi+6mgyP3A26HcaS1c3w/hrw=; b=f4vkNMMAFOr2uYTzzDddy+dT43rbMSvA3ErDKRjTr4CJkUs7JC0N4UcS8ehTQEHIDt tXeUKFLu5d2ARJjxcHrW5Wk7ImM69CNJaQ0g62yekIaOBtyQ20WL1ZrLVn+od6I5nW/K IYdnYRez+dlQ9o3xpEkeL+UcMgx4Jh5yXVFaTJUI+fmMxuW6pNIuEi0F8pVLZ35Es1B7 uFu3lIcA+IizpNsyFoMFkcLwLCmNTvD1+i+fknEvw4nAvZZ+I8Bz7Op4RZAnMQGs6S3R 3eqD0UztwsKHg33DWameorKtDGQliPw+/Ccbnna48f4A1fBsKf6NEr3jVnhhYSG76LQI 9Pqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uiSsL3jb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y18si1054605pgf.247.2019.03.20.00.25.57; Wed, 20 Mar 2019 00:26:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uiSsL3jb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727555AbfCTHY1 (ORCPT + 99 others); Wed, 20 Mar 2019 03:24:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:53948 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbfCTHY1 (ORCPT ); Wed, 20 Mar 2019 03:24:27 -0400 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 823F121841; Wed, 20 Mar 2019 07:24:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553066667; bh=LKSGoa7DsIhXCSg0GT6TmhCEBzU9cUCmQC9JwaSOddg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uiSsL3jbW9n6vDtU4OiEnJkf3hibFnU86PaeRywVD1pijTWvtiuLM485j/4yJjIrq MlVbh07E9GsGkDYbwzPWaqv6FsjpwGFnVKx8GccIqa5Z7Cqt9gGRXrM+hfZ8/wC4jU nqb7Iw/p3jAnJHBAVqesI+6HyZCH1beKfsvwjYx4= Date: Wed, 20 Mar 2019 08:24:24 +0100 From: Greg Kroah-Hartman To: Aditya Pakki Cc: devel@driverdev.osuosl.org, Arnd Bergmann , kjlu@umn.edu, linux-kernel@vger.kernel.org, Hardik Singh Rathore , Hans de Goede , Colin Ian King , Nathan Chancellor , Larry Finger Subject: Re: [PATCH v2] staging: rtl8188eu: Fix potential NULL pointer dereference Message-ID: <20190320072424.GD2647@kroah.com> References: <20190319210801.19074-1-pakki001@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190319210801.19074-1-pakki001@umn.edu> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 19, 2019 at 04:07:54PM -0500, Aditya Pakki wrote: > hwxmits is allocated via kcalloc and not checked for failure before its > dereference. The patch fixes this problem by returning an error in > rtl8723bs. > > --- > v1: Return error and remove print in case of failure, per Greg > Signed-off-by: Aditya Pakki Please fix.