Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp300857img; Wed, 20 Mar 2019 00:36:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8+t3oE5sXdEVlShZvfCtn/z0RBk228pvrn6SECOrjtC3BbwpIqgNcACD3LBQj55y8QoNb X-Received: by 2002:a17:902:248:: with SMTP id 66mr6589252plc.286.1553067405931; Wed, 20 Mar 2019 00:36:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553067405; cv=none; d=google.com; s=arc-20160816; b=cQMPapmgmx3YkXhos44vP6b0lMfCn1QNCI9Sf+AN9UNymxAFwnOKzcgbYh4Pg6qu5/ Zc4OcrnOyZRGnsLRH6De4LkEYJjJo7t9lAcCjOMAnj25A1/isQeS8L9SaH9LFy9ZqNqj SQMNXQJFojYdE2jslwhnPb3g3ELaIGz/vmEiyU54mgX2Ef8drkFuyO9ouFEBf0uELDYF 8ZxTDhn7xMpoBzqhWc0N7SUkjW5/UpQd5u11k7t3cpynXJ77eUnCY+HcPYw7COqPJur2 O+89Fa0EEREYxOUjGyFrvAK/Q8xSds7M/D1QPU0MbCGQN4nA3msDAAYyQlVZGy8V2bwb Joyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=tuB9PNNGBdrtgxjPzbnq4e1RMAH2qhJJfR1+/49znvY=; b=VjT+SujHFttN8u+qmseMGnELoj6Zt/PcZqbXKvAcPTct0Y8jX+6aNB30fTvcoSfTtH tYd1y5lGqg0U48iHqBAY8sOOplOnlRwR7jrtc2jcjv+9mkObl9IonzyB7fqg1izNm4nu UzJUmSDPNDW9OtevgqqVMtFkon2AVJP/48KRDrBSJNOptEh1u3APlLr+i+uoKtKVpRkF T/S7ZcQDulvxVcE4orY/fVm7otCEjWf57Lc/GfWfHCA5oTDKq2tNiRmhrZzx09uwOk5q uF+IQg4ZhvmHfRes2w8c3l5x4kkZ7zqLabNf+gMd6bDQddhw+g1XrQVwOltEObcLZICa ljMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t22si1243785plo.79.2019.03.20.00.36.30; Wed, 20 Mar 2019 00:36:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727434AbfCTHfy (ORCPT + 99 others); Wed, 20 Mar 2019 03:35:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33136 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbfCTHfy (ORCPT ); Wed, 20 Mar 2019 03:35:54 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4948F58E45; Wed, 20 Mar 2019 07:35:54 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-38.pek2.redhat.com [10.72.12.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id AD6D96B499; Wed, 20 Mar 2019 07:35:47 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, pasha.tatashin@oracle.com, mhocko@suse.com, rppt@linux.vnet.ibm.com, richard.weiyang@gmail.com, linux-mm@kvack.org, Baoquan He Subject: [PATCH 1/3] mm/sparse: Clean up the obsolete code comment Date: Wed, 20 Mar 2019 15:35:38 +0800 Message-Id: <20190320073540.12866-1-bhe@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 20 Mar 2019 07:35:54 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The code comment above sparse_add_one_section() is obsolete and incorrect, clean it up and write new one. Signed-off-by: Baoquan He --- mm/sparse.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/mm/sparse.c b/mm/sparse.c index 77a0554fa5bd..0a0f82c5d969 100644 --- a/mm/sparse.c +++ b/mm/sparse.c @@ -674,9 +674,12 @@ static void free_map_bootmem(struct page *memmap) #endif /* CONFIG_SPARSEMEM_VMEMMAP */ /* - * returns the number of sections whose mem_maps were properly - * set. If this is <=0, then that means that the passed-in - * map was not consumed and must be freed. + * sparse_add_one_section - add a memory section + * @nid: The node to add section on + * @start_pfn: start pfn of the memory range + * @altmap: device page map + * + * Return 0 on success and an appropriate error code otherwise. */ int __meminit sparse_add_one_section(int nid, unsigned long start_pfn, struct vmem_altmap *altmap) -- 2.17.2