Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp316322img; Wed, 20 Mar 2019 01:01:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqxDEqKuh35twT53dSotblXUr+Mdmfa0ItL6lVaNMgCx1pqu6QGVRJ2G6TsIGrQU0SFp4BXa X-Received: by 2002:a63:fd03:: with SMTP id d3mr6362333pgh.359.1553068875628; Wed, 20 Mar 2019 01:01:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553068875; cv=none; d=google.com; s=arc-20160816; b=aLEpD+scnvJ7H1bQodV7jaah5nVJ4lQRBYPNedkunk7IsPHIesd33JplGfw1LroSHC o6flBCdWGLIX8yA/XNq7cYi7QFFieQyqJnKFmwgCYiMRDuUmnfrsAR3MZZdrBCpqXZpW 7owpgD20m/SuXqBAYCbwaMf51S5X5jGMtnyy1NSqP1kr15EJA6UxUffRdZK8AWh5VlcA g386x5YJKC64kXAj/w9GqL40TuR2IedS3doaQ9IvmS3RV+KC4Tw6gVYZh5JvITmKL0jZ 4QbZOvFMv9ru6BYiN/N19EXqm1RR6NFWJaFq+7o4G2Uw7Xst0odWuD84asn8D7gedA5j 3KSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=zIkvq2NA7Nd91AnSX4+S2o8nn3TJRHaoKnp3ci1iuVI=; b=cedKW4d/MsQ1S+SPyr9c8vG1gl8ZNs5Mt80dDeaoZwPumcuFeL8XlLondSEY3zYy64 JKmKgzqfDkgSibCkr3GrhdbllK6b47YfvQab6nohUi+DwR4M4y5EacA7KA+mD96g+zPD ngCgECH+7bNUAQxUR8cJxlnnnGboz9II7eC0fIlSMNbo6XWHO/tydsXES8gHM3LixCc9 yFcEYMf/YwqJTeHIf+z33hK5RIIKLObE2+/2FoJWE7rEYOMG0eykgAg9zfQgVS1+Hldr J14DcnmHz51igBwNDyeGzQFcFxH3wAkHMOJHb164/WoSKTjrCwpxCb1qVveLBe3ZhsUS wWdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k129si1123625pfc.45.2019.03.20.01.00.59; Wed, 20 Mar 2019 01:01:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727528AbfCTIAO (ORCPT + 99 others); Wed, 20 Mar 2019 04:00:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51844 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725942AbfCTIAO (ORCPT ); Wed, 20 Mar 2019 04:00:14 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3235DC057F9A; Wed, 20 Mar 2019 08:00:14 +0000 (UTC) Received: from localhost (ovpn-12-38.pek2.redhat.com [10.72.12.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E0465D70A; Wed, 20 Mar 2019 08:00:11 +0000 (UTC) Date: Wed, 20 Mar 2019 16:00:08 +0800 From: Baoquan He To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, pasha.tatashin@oracle.com, mhocko@suse.com, rppt@linux.vnet.ibm.com, richard.weiyang@gmail.com, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm/sparse: Clean up the obsolete code comment Message-ID: <20190320080008.GK18740@MiWiFi-R3L-srv> References: <20190320073540.12866-1-bhe@redhat.com> <20190320075058.GB13626@rapoport-lnx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190320075058.GB13626@rapoport-lnx> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 20 Mar 2019 08:00:14 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/20/19 at 09:50am, Mike Rapoport wrote: > Hi, > > On Wed, Mar 20, 2019 at 03:35:38PM +0800, Baoquan He wrote: > > The code comment above sparse_add_one_section() is obsolete and > > incorrect, clean it up and write new one. > > > > Signed-off-by: Baoquan He > > --- > > mm/sparse.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/mm/sparse.c b/mm/sparse.c > > index 77a0554fa5bd..0a0f82c5d969 100644 > > --- a/mm/sparse.c > > +++ b/mm/sparse.c > > @@ -674,9 +674,12 @@ static void free_map_bootmem(struct page *memmap) > > #endif /* CONFIG_SPARSEMEM_VMEMMAP */ > > > > /* > > - * returns the number of sections whose mem_maps were properly > > - * set. If this is <=0, then that means that the passed-in > > - * map was not consumed and must be freed. > > + * sparse_add_one_section - add a memory section > > Please mention that this is only intended for memory hotplug Will do. Thanks for reviewing. > > > + * @nid: The node to add section on > > + * @start_pfn: start pfn of the memory range > > + * @altmap: device page map > > + * > > + * Return 0 on success and an appropriate error code otherwise. > > s/Return/Return:/ please Thanks, will change. > > > */ > > int __meminit sparse_add_one_section(int nid, unsigned long start_pfn, > > struct vmem_altmap *altmap) > > -- > > 2.17.2 > > > > -- > Sincerely yours, > Mike. >