Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 20 Mar 2019 16:11:12 +0800
From:   Ming Lei <ming.lei@redhat.com>
To:     zhengbin <zhengbin13@huawei.com>
Cc:     axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, houtao1@huawei.com,
        yanaijie@huawei.com, yuyufen@huawei.com
Subject: Re: [PATCH] blk-mq: fix a hung issue when set device state to
 blocked and restore running
Message-ID: <20190320081110.GA8408@ming.t460p>
References: <1553068921-6605-1-git-send-email-zhengbin13@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1553068921-6605-1-git-send-email-zhengbin13@huawei.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 20, 2019 at 04:02:01PM +0800, zhengbin wrote:
> When I use dd test a SCSI device which use blk-mq in the following steps:
> 1.echo "blocked" >/sys/block/sda/device/state
> 2.dd if=/dev/sda of=/mnt/t.log bs=1M count=10
> 3.echo "running" >/sys/block/sda/device/state
> dd should finish this work after step 3, unfortunately, still hung.
> 
> After step2, the key code process is like this:
> blk_mq_dispatch_rq_list-->scsi_queue_rq-->prep_to_mq
>                        -->if ret is BLK_STS_RESOURCE, delay run hw queue
> 
> prep_to_mq will return BLK_STS_RESOURCE, and scsi_queue_rq will transter
> it to BLK_STS_DEV_RESOURCE. In this situtation, we should delay run hw

BLK_STS_DEV_RESOURCE means that the driver will rerun hw queue, so
maybe you need to investigate why it is returned from scsi driver first.

BTW, I'd suggest you read the big comment on BLK_STS_DEV_RESOURCE first.

Thanks,
Ming