Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 20 Mar 2019 09:14:21 +0100 (CET)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Roman Kiryanov <rkir@google.com>
cc:     LKML <linux-kernel@vger.kernel.org>,
        Sebastian Reichel <sebastian.reichel@collabora.com>,
        Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] drivers: power: supply: goldfish_battery: Fix bogus SPDX
 identifier
In-Reply-To: <CAOGAQepj=yW4uQSRHpvnQz71+D8a7+H71XtrApp8YGU65XgoqA@mail.gmail.com>
Message-ID: <alpine.DEB.2.21.1903200905380.1816@nanos.tec.linutronix.de>
References: <alpine.DEB.2.21.1903191529010.2537@nanos.tec.linutronix.de> <CAOGAQepj=yW4uQSRHpvnQz71+D8a7+H71XtrApp8YGU65XgoqA@mail.gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?

On Tue, 19 Mar 2019, Roman Kiryanov wrote:
> Hi, I am sorry for this warning. I remember I checked all changes I
> sent, maybe missed this one.
> 
> At the bottom the file says
> 
> MODULE_LICENSE("GPL");
> 
> and
> 
> // SPDX-License-Identifier: GPL-2.0
> 
> makes it inconsistent.

No. It does not.

 1) The module license is not a precise license indicator.

 2) SPDX License identifiers are well defined and standardized. 'GPL' is
    NOT a valid SPDX identifier.

The usage of SPDX identifiers and the relevance of the MODULE_LICENSE()
string are well documented in:

    Documentation/process/license-rules.rst

or for your conveniance at:

    https://www.kernel.org/doc/html/latest/process/license-rules.html

Thanks,

	tglx