Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: WXU+rwwh/2StGNNA0EzHogoIhiBN79nS8MTeV8jIb0PbBn3JPIQHqG4yTd4inYaQQvA0QOhTfj
 WGgbYY9qMoFibAeNGF9FmQ+3L4MBBEa7+nsMDHYz/zyzM3Fi51oOZxLtXs5EsqkWxwHEwt8cxq
 xuDKmV7KYNR21ZkHTDMy33RWkJiJCY/R1umXI+S6oe7s3X9FnZyJDr9YfV6TiTbad+64NwAN85
 TMoqAgBKdTdA/XOF9KkWXCZMudMQxNegFoftnhKKGWBQgZaKSC5x+i4DsyPcbTQI6g4GH1xXm0
 HXY=
Subject: Re: [PATCH v2] usb: usb251xb: fix to avoid potential NULL pointer
 dereference
To:     Aditya Pakki <pakki001@umn.edu>
CC:     <kjlu@umn.edu>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20190319202658.17116-1-pakki001@umn.edu>
From:   Richard Leitner <richard.leitner@skidata.com>
Message-ID: <593fcaca-8732-94b0-08fb-b1c6738cd688@skidata.com>
Date:   Wed, 20 Mar 2019 11:00:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <20190319202658.17116-1-pakki001@umn.edu>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi, thanks for the updated patch.

Please find my comments below.

On 19/03/2019 21:26, Aditya Pakki wrote:
> of_match_device in usb251xb_probe can fail and returns a NULL pointer.
> The patch avoids a potential NULL pointer dereference in this scenario.
> 
> --

This should be 3 dashes "---" ;-)

> v1: Fix to avoid return in case of error, per Richard's suggestion.
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>

This signed-off-by line should be in the commit message, not the 
"version history" which is not included in the commit.

Apart from that (if you send a fixed v3) feel free to add
	Reviewed-by: Richard Leitner <richard.leitner@skidata.com>

regards;Richard.L

> ---
>   drivers/usb/misc/usb251xb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
> index 4d72b7d1d383..bbfdb7447d6f 100644
> --- a/drivers/usb/misc/usb251xb.c
> +++ b/drivers/usb/misc/usb251xb.c
> @@ -612,7 +612,7 @@ static int usb251xb_probe(struct usb251xb *hub)
>   							   dev);
>   	int err;
>   
> -	if (np) {
> +	if (np && of_id) {
>   		err = usb251xb_get_ofdata(hub,
>   					  (struct usb251xb_data *)of_id->data);
>   		if (err) {
>