Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp426821img; Wed, 20 Mar 2019 03:41:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqyct4XieaQxgLw+9Ca/NZB5M16rR7lukQS5YaUBAIxuReuxvVKT6hfL5U60lTgu3LtmzQVK X-Received: by 2002:a17:902:10d:: with SMTP id 13mr23323236plb.230.1553078478951; Wed, 20 Mar 2019 03:41:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553078478; cv=none; d=google.com; s=arc-20160816; b=ji8hlkMCQf1FZktGks67hzRWcS1fQSAKfbqQycFe8RX5qSAbHptRXokMB5QRSOxL6V AcM2FSZTNnTJFo4DtZ5qBks+vjgwLq4t1Z+/vxyj1ZAVwffUa8nVLXlyhcQLoLMvxFwE BSb6J+JLUWmI8Te77dN1USOOFtkxZns78kHOVWY54pSE+cHyjFU/3iEqv5bvIZbnausZ Lpd0IZjKL2lgQfKY5KUEhYQrPVTfWjDHwi148qqKQJ+ufd51vvZVUOVLluhnTUUuOohg JzZLdHNwy0lbf29u/NlEvxzrm0HBwc+PzgIm0dgzqEhNO9pMKvnu2ICh3FjuOKJU3u9c oD1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=jmTWTsjVde8Buo2u+HYWbLOnOnpUNQfeTfb58oufkzI=; b=PKT7b12TtRS5FXx9djI7vlYdzMDeG9oP4vaHBa5c5K/njA/Xy560OuWyY6Yp9phy00 +zx7TUn8U1alI12KRMIo7lFCffdSJfMBHOWLUi8EJFBbLWCl50+jKRP+E3m3C9Md3XKB q1JyDNi2+vJxkl7dPWAtwfLOP6QA9V4uyzWyUg/JeX+gQTwJz0v9XUkZl8alCU4RS/5B aDicB6LZfCsmJ4tTO4JDiYrKzsIRoldRqzXOmz4yh6NcYuA9cQLJul0ZnLnXWo62x3sP 6zV98JXbaH7eWEW9UXjItrQZeJZ/oyy4v7aA2hNj0PkvO1LgvroIo/4Iu+Z2I9gYSOyI gn2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=QJ0Hixfu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u4si1396737pgh.278.2019.03.20.03.41.03; Wed, 20 Mar 2019 03:41:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=QJ0Hixfu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727598AbfCTKid (ORCPT + 99 others); Wed, 20 Mar 2019 06:38:33 -0400 Received: from mail-it1-f195.google.com ([209.85.166.195]:37543 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726506AbfCTKic (ORCPT ); Wed, 20 Mar 2019 06:38:32 -0400 Received: by mail-it1-f195.google.com with SMTP id z124so31721918itc.2 for ; Wed, 20 Mar 2019 03:38:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jmTWTsjVde8Buo2u+HYWbLOnOnpUNQfeTfb58oufkzI=; b=QJ0Hixfu5hcP+OFD1pi83mFWhFYFQQSuLAY5azSzK1Z0hCoctBQFEUwJ3f+Y/VGYEs 3PrcLIjfbZB1UJki9W2oG8Yvj7/3C8jMjCHX8G7+CvIhafbtBJUq/RVj7VtbdIQlLxyv IyabyWBUzqVe8JITAbfCLJ8ln9FqUkgcwKaXhMwHvHpGMR0AUoCE0zClrsX7pJPc2LOP Y7bIuhc4F9jTAxR/SGC2rNDbUNXrPorOtIJoaoQgmOaIs+INa7CDUpL7zCU/HQOuCrmt 9UYNEZvjD7PjjoK7qcv0p5ONx5+qNWVQSKus6VlZjbyYmKVSreGt8Gpn5cVtS0uiOJBe sbIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jmTWTsjVde8Buo2u+HYWbLOnOnpUNQfeTfb58oufkzI=; b=oC9349YZXuf1vq1UUEiDwZ89EVcDIqaXnwjCJmdLV4as+NyGnzYE+6iYRSjBjvK6aC jErm0JOxP0dn9mjiS1KpFtOjLkMQPgFa6Fpe/qlbIEDVPLYu6kHMzXjh6obS5UVx4c+P 6wfGeCxz2xFboA0xN5yZdvfcYAC0eOu5AKDSsFIaN1XhMNXxK08H9XBUaF/sbesw6Ee3 6b08hpOV20s01z7xw8gRlbUym2r/+ZfYhgGqp5Ntbs28FpYoq9A/4WerzN/flHPkS93w sw/yKIbkcRw485Rt78yTyF0xJ6bH6TcYYqoO4nzXHmUSE32lLnzConrqE7GkiAn+hWZ6 /u9Q== X-Gm-Message-State: APjAAAVtUhevseuZ3UBfPP+d1EjxXSKeZmoBAhIUG+gVV1GbFnaQ1zvW k8+8eDQFgbLQlAorJUSvXvqp9oqgWM+JdmPWyoNglQ== X-Received: by 2002:a05:6638:211:: with SMTP id e17mr3466378jaq.35.1553078311470; Wed, 20 Mar 2019 03:38:31 -0700 (PDT) MIME-Version: 1.0 References: <000000000000db3d130584506672@google.com> <426293c3-bf63-88ad-06fb-83927ab0d7c0@I-love.SAKURA.ne.jp> In-Reply-To: <426293c3-bf63-88ad-06fb-83927ab0d7c0@I-love.SAKURA.ne.jp> From: Dmitry Vyukov Date: Wed, 20 Mar 2019 11:38:20 +0100 Message-ID: Subject: Re: kernel panic: corrupted stack end in wb_workfn To: Tetsuo Handa Cc: Andrey Ryabinin , syzbot , Andrew Morton , Qian Cai , David Miller , guro@fb.com, Johannes Weiner , Josef Bacik , Kirill Tkhai , LKML , Linux-MM , linux-sctp@vger.kernel.org, Mel Gorman , Michal Hocko , netdev , Neil Horman , Shakeel Butt , syzkaller-bugs , Al Viro , Vladislav Yasevich , Matthew Wilcox , Xin Long Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 20, 2019 at 11:24 AM Tetsuo Handa wrote: > > On 2019/03/20 18:59, Dmitry Vyukov wrote: > >> From bisection log: > >> > >> testing release v4.17 > >> testing commit 29dcea88779c856c7dc92040a0c01233263101d4 with gcc (GCC) 8.1.0 > >> run #0: crashed: kernel panic: corrupted stack end in wb_workfn > >> run #1: crashed: kernel panic: corrupted stack end in worker_thread > >> run #2: crashed: kernel panic: Out of memory and no killable processes... > >> run #3: crashed: kernel panic: corrupted stack end in wb_workfn > >> run #4: crashed: kernel panic: corrupted stack end in wb_workfn > >> run #5: crashed: kernel panic: corrupted stack end in wb_workfn > >> run #6: crashed: kernel panic: corrupted stack end in wb_workfn > >> run #7: crashed: kernel panic: corrupted stack end in wb_workfn > >> run #8: crashed: kernel panic: Out of memory and no killable processes... > >> run #9: crashed: kernel panic: corrupted stack end in wb_workfn > >> testing release v4.16 > >> testing commit 0adb32858b0bddf4ada5f364a84ed60b196dbcda with gcc (GCC) 8.1.0 > >> run #0: OK > >> run #1: OK > >> run #2: OK > >> run #3: OK > >> run #4: OK > >> run #5: crashed: kernel panic: Out of memory and no killable processes... > >> run #6: OK > >> run #7: crashed: kernel panic: Out of memory and no killable processes... > >> run #8: OK > >> run #9: OK > >> testing release v4.15 > >> testing commit d8a5b80568a9cb66810e75b182018e9edb68e8ff with gcc (GCC) 8.1.0 > >> all runs: OK > >> # git bisect start v4.16 v4.15 > >> > >> Why bisect started between 4.16 4.15 instead of 4.17 4.16? > > > > Because 4.16 was still crashing and 4.15 was not crashing. 4.15..4.16 > > looks like the right range, no? > > No, syzbot should bisect between 4.16 and 4.17 regarding this bug, for > "Stack corruption" can't manifest as "Out of memory and no killable processes". > > "kernel panic: Out of memory and no killable processes..." is completely > unrelated to "kernel panic: corrupted stack end in wb_workfn". Do you think this predicate is possible to code? Looking at the examples we have, distinguishing different bugs does not look feasible to me. If the predicate is not accurate, you just trade one set of false positives to another set of false positives and then you at the beginning of an infinite slippery slope refining it. Also, if we see a different bug (assuming we can distinguish them), does it mean that the original bug is not present? Or it's also present, but we just hit the other one first? This also does not look feasible to answer. And if you give a wrong answer, bisection goes the wrong way and we are where we started. Just with more complex code and things being even harder to explain to other people. I mean, yes, I agree, kernel bug bisection won't be perfect. But do you see anything actionable here?