Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1552974845-1590-1-git-send-email-harini.katakam@xilinx.com> <74d29e0e-d55e-e983-add1-361f7c4af948@microchip.com>
In-Reply-To: <74d29e0e-d55e-e983-add1-361f7c4af948@microchip.com>
From:   Harini Katakam <harinik@xilinx.com>
Date:   Wed, 20 Mar 2019 16:16:22 +0530
Message-ID: <CAFcVECKqatju7P7WAR0cLGePkAvDcJ8Sb-KKxvjpvtNuEtWSWw@mail.gmail.com>
Subject: Re: [RFC PATCH] net: macb: Add null check for PCLK and HCLK
To:     Claudiu Beznea <Claudiu.Beznea@microchip.com>
Cc:     Harini Katakam <harini.katakam@xilinx.com>,
        Nicolas Ferre <Nicolas.Ferre@microchip.com>,
        David Miller <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Michal Simek <michal.simek@xilinx.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Claudiu,

On Tue, Mar 19, 2019 at 9:51 PM <Claudiu.Beznea@microchip.com> wrote:
>
>
>
> On 19.03.2019 07:54, Harini Katakam wrote:
<snip>
> > -     if (IS_ERR(*pclk)) {
> > +     if (IS_ERR(*pclk) || (*pclk == NULL)) {
>
> You can use IS_ERR_OR_NULL() macro.
>
Yes will fix, thanks.
Also the error code from this function will end up being 0 below
even if pointer is NULL. Will fix that.

Regards,
Harini

> >               err = PTR_ERR(*pclk);
> >               dev_err(&pdev->dev, "failed to get macb_clk (%u)\n", err);
> >               return err;
> >       }