Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Aditya Pakki' <pakki001@umn.edu>
CC:     "kjlu@umn.edu" <kjlu@umn.edu>,
        Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Yehezkel Bernat <YehezkelShB@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <jakub.kicinski@netronome.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "xdp-newbies@vger.kernel.org" <xdp-newbies@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: RE: [PATCH] thunderbolt: xdomain: Fix to check return value of
 kmemdup
Thread-Topic: [PATCH] thunderbolt: xdomain: Fix to check return value of
 kmemdup
Thread-Index: AQHU3d3P6yfm6q4n/EWUAqU+kGwm2qYUW5Hg
Date:   Wed, 20 Mar 2019 10:57:54 +0000
Message-ID: <57793438545e41cc85d00beab7505143@AcuMS.aculab.com>
References: <20190318225508.7886-1-pakki001@umn.edu>
In-Reply-To: <20190318225508.7886-1-pakki001@umn.edu>
Accept-Language: en-GB, en-US
Content-Language: en-US
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Aditya Pakki
> Sent: 18 March 2019 22:55
> 
> kmemdup can fail and return a NULL pointer. The patch modifies the
> signature of tb_xdp_schedule_request and passes the failure error upstream.
> 
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
>  drivers/thunderbolt/xdomain.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c
> index e27dd8beb94b..b0e9cc30d708 100644
> --- a/drivers/thunderbolt/xdomain.c
> +++ b/drivers/thunderbolt/xdomain.c
> @@ -526,7 +526,7 @@ static void tb_xdp_handle_request(struct work_struct *work)
>  	kfree(xw);
>  }
> 
> -static void
> +static bool
>  tb_xdp_schedule_request(struct tb *tb, const struct tb_xdp_header *hdr,
>  			size_t size)
>  {
> @@ -534,13 +534,16 @@ tb_xdp_schedule_request(struct tb *tb, const struct tb_xdp_header *hdr,
> 
>  	xw = kmalloc(sizeof(*xw), GFP_KERNEL);
>  	if (!xw)
> -		return;
> +		return false;
> 
>  	INIT_WORK(&xw->work, tb_xdp_handle_request);
>  	xw->pkg = kmemdup(hdr, size, GFP_KERNEL);
> +	if (!xw->pkg)
> +		return false;

You're leaking 'xw' here.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)