Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp515420img; Wed, 20 Mar 2019 05:34:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqzCYfemWSOpm7zsgZ7UO7RG1Yc1+Y2KbUVwfm65J1I5muvSSoP/jsDlYCfQwGCZs9eoAbG5 X-Received: by 2002:a17:902:361:: with SMTP id 88mr7838042pld.78.1553085244057; Wed, 20 Mar 2019 05:34:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553085244; cv=none; d=google.com; s=arc-20160816; b=xwOePfio0h4qMIocfwnA+hCCIFalBAp3OwWULT93vxvmGiJEGud2jHg1+5SvLoj1VE LNX4aXntPHdA44PjgR8tUNKsFx+ms8NVRopkZtC1lw67tzaZNdzq6LFAU7JxNL6+qByY zKUO7xHKpFTD3povLwkcYUeL62Zd6IkU+0rDAzzc3auEh6GZdY4GvNYMPnh55Jqhv7ne TYZSRHo/baEzJMyerHK9h+P4CIpkRs/zpFx8Ndfm7m3tdwtFgHkjyghfYT8bwS/CGxy3 PCQwpjezWPZCU20DidKFeyp/8KvO0vD90dVE2gQ1isKTqxbLjXnyzCDXL2oVu0JhlOQw 6ZQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=zYXIjKo7obifc+/4Zjs1UpdakUFP0r15uXojk2DQY3o=; b=0we9I7HDdwoJY/8QvXmN3HJYcs7CEWJ72O/GEQUVCMlSlLCz2VUs5/MGMOilr35Ir+ hYGJT8sCXEf/vjCA4pU3cbDNGSnS9uWVXLYj0tLcqnMersZbrVIG2I0sSKQA8TrC7axI WW0eFdmEsE5DZabOq0g5OaxDejSBzhr7mY8xAcJFhHDtH7bTRCs9M1rnZgn09NmzbKEt hHLI3M91XnxDAR/bZORLuBCe2scLGRiK23ZT+qVUDOsZ6nkDkgoU1J6MXUB4MpmyF438 fsRRYFlWWBwHG7QcY3mI4i4nn+6/KXrxuk2bd2g46ohMOio3OXmjrKLJf6PvEAG4E+L+ w/ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i11si1857379plb.177.2019.03.20.05.33.48; Wed, 20 Mar 2019 05:34:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727843AbfCTMdC (ORCPT + 99 others); Wed, 20 Mar 2019 08:33:02 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:33877 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727524AbfCTMdB (ORCPT ); Wed, 20 Mar 2019 08:33:01 -0400 X-Originating-IP: 182.72.246.220 Received: from localhost (unknown [182.72.246.220]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id D15C11BF20E; Wed, 20 Mar 2019 12:32:58 +0000 (UTC) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 5/7] rtc: xgene: stop caching alarm_time Date: Wed, 20 Mar 2019 13:32:31 +0100 Message-Id: <20190320123233.13519-5-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190320123233.13519-1-alexandre.belloni@bootlin.com> References: <20190320123233.13519-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no point in caching alarm_time for .read_alarm because .read_alarm is only called at boo time and thus alarm_time is always 0. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-xgene.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-xgene.c b/drivers/rtc/rtc-xgene.c index eb745deda936..6f7d7648a9bd 100644 --- a/drivers/rtc/rtc-xgene.c +++ b/drivers/rtc/rtc-xgene.c @@ -35,7 +35,6 @@ struct xgene_rtc_dev { struct rtc_device *rtc; struct device *dev; - unsigned long alarm_time; void __iomem *csr_base; struct clk *clk; unsigned int irq_wake; @@ -68,7 +67,8 @@ static int xgene_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) { struct xgene_rtc_dev *pdata = dev_get_drvdata(dev); - rtc_time_to_tm(pdata->alarm_time, &alrm->time); + /* If possible, CMR should be read here */ + rtc_time_to_tm(0, &alrm->time); alrm->enabled = readl(pdata->csr_base + RTC_CCR) & RTC_CCR_IE; return 0; @@ -105,8 +105,7 @@ static int xgene_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) unsigned long alarm_time; rtc_tm_to_time(&alrm->time, &alarm_time); - pdata->alarm_time = alarm_time; - writel((u32)pdata->alarm_time, pdata->csr_base + RTC_CMR); + writel((u32)alarm_time, pdata->csr_base + RTC_CMR); xgene_rtc_alarm_irq_enable(dev, alrm->enabled); -- 2.20.1