Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6EB7E615BE
Subject: Re: [PATCH] thunderbolt: Fix to check return value of ida_simple_get
To:     Aditya Pakki <pakki001@umn.edu>
Cc:     kjlu@umn.edu, Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Yehezkel Bernat <YehezkelShB@gmail.com>,
        linux-kernel@vger.kernel.org
References: <20190319172259.8874-1-pakki001@umn.edu>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <6e3d1501-be71-ac95-2f47-ab928b3bc026@codeaurora.org>
Date:   Wed, 20 Mar 2019 18:24:00 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20190319172259.8874-1-pakki001@umn.edu>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/19/2019 10:52 PM, Aditya Pakki wrote:
> ida_simple_get on failure can return an error. The patch ensures that
> the dev_set_name is set on non failure cases.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---


We should add check against `ida_simple_get` instead of svc->id >= 0 and 
clean up  svc.

Also, It seems clean up is missing when device_register fails and it is 
leaking svc.

Cheers,
Mukesh


>   drivers/thunderbolt/xdomain.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c
> index e27dd8beb94b..b1768f595259 100644
> --- a/drivers/thunderbolt/xdomain.c
> +++ b/drivers/thunderbolt/xdomain.c
> @@ -772,7 +772,9 @@ static void enumerate_services(struct tb_xdomain *xd)
>   		svc->dev.bus = &tb_bus_type;
>   		svc->dev.type = &tb_service_type;
>   		svc->dev.parent = &xd->dev;
> -		dev_set_name(&svc->dev, "%s.%d", dev_name(&xd->dev), svc->id);
> +		if (svc->id >= 0)
> +			dev_set_name(&svc->dev, "%s.%d", dev_name(&xd->dev),
> +					svc->id);
>   
>   		if (device_register(&svc->dev)) {
>   			put_device(&svc->dev);