Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp597590img; Wed, 20 Mar 2019 07:08:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqzGRBFQ42RXnJ8onQHrSwr7dHVM5DHKOEIo+h0EH5jDLjUOAlGWlpozmrFqDB/92cPe9+H5 X-Received: by 2002:a63:c64c:: with SMTP id x12mr7631070pgg.285.1553090888967; Wed, 20 Mar 2019 07:08:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553090888; cv=none; d=google.com; s=arc-20160816; b=0K+ST3U7ozYbyc5S/L2LGxxr8XNvvhv6s0uN7UNaLAfpV4d0gkkWe7R/0n1cweEX6/ dBILwA7+1MP69IyzU/uaaOhN6IgzMTFvORaTTjMlsKCKCuAfj4WpZB8QtY5LpLVR+C8V FKsAzm8kvDJxOo6hOpfTZcP7As9bywggkPZDuw5M/hX6T5wrWkCgqk8SDIRCteFGnHef Wlvfm/uJdIkqy7iRsYmEb7Y8cm16P9+BTYQfELFq5l/iGBWNyQqrn+ZZcjXeHh6SU4Cu zSIeDnRH3BYzggmrCyTciYyCvV3qlmGJq6R9PhX1RW/i7rI4n1wZid2stZ21dUkiHDqp MNdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=BjRVWAY7Yzmi3WdvkMtCHL9KfX1Ez4HAedyVKzdyNF8=; b=qhKiWB8NiLQ4cQkz1wUfH4PWhQvZGXbzBDW2lK+xgHE4U2Z08CbirDUXIdbb37fXhW hfPc1J7ID/fFAJuZ0/P5HMdNT5ut/nIb5WgvYwhk43zGk3b9xt7kiJVUlZyioRCo+5HO 41QfELYWWqGJHJksmEAed5SIacrzGntlS95Aht5a9iQRjslPAHriS1Pivp7a0KdEeJ01 lFQ/qGJEcCkWLdv/N/hHpJwO9oWGnzLq7P5JteTEB2OaXIN+l8VfUeT5ru2YuilNKVvN 1pVqkNzC/WX5jF1Qt6K6BB/4i/favSSKhtkr4nvh3z3yRyh6BgjqBaoywlHH25NDXqVG UrZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k129si1789024pfc.45.2019.03.20.07.07.52; Wed, 20 Mar 2019 07:08:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728122AbfCTLxj (ORCPT + 99 others); Wed, 20 Mar 2019 07:53:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17955 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726448AbfCTLxh (ORCPT ); Wed, 20 Mar 2019 07:53:37 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D47D03084259; Wed, 20 Mar 2019 11:53:36 +0000 (UTC) Received: from localhost (ovpn-12-38.pek2.redhat.com [10.72.12.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1BE516014E; Wed, 20 Mar 2019 11:53:35 +0000 (UTC) Date: Wed, 20 Mar 2019 19:53:33 +0800 From: Baoquan He To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, pasha.tatashin@oracle.com, mhocko@suse.com, rppt@linux.vnet.ibm.com, richard.weiyang@gmail.com, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm/sparse: Clean up the obsolete code comment Message-ID: <20190320115333.GR18740@MiWiFi-R3L-srv> References: <20190320073540.12866-1-bhe@redhat.com> <20190320111959.GV19508@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190320111959.GV19508@bombadil.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Wed, 20 Mar 2019 11:53:37 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/20/19 at 04:19am, Matthew Wilcox wrote: > On Wed, Mar 20, 2019 at 03:35:38PM +0800, Baoquan He wrote: > > /* > > - * returns the number of sections whose mem_maps were properly > > - * set. If this is <=0, then that means that the passed-in > > - * map was not consumed and must be freed. > > + * sparse_add_one_section - add a memory section > > + * @nid: The node to add section on > > + * @start_pfn: start pfn of the memory range > > + * @altmap: device page map > > + * > > + * Return 0 on success and an appropriate error code otherwise. > > */ > > I think it's worth documenting what those error codes are. Seems to be > just -ENOMEM and -EEXIST, but it'd be nice for users to know what they > can expect under which circumstances. > > Also, -EEXIST is a bad errno to return here: > > $ errno EEXIST > EEXIST 17 File exists > > What file? I think we should be using -EBUSY instead in case this errno > makes it back to userspace: > > $ errno EBUSY > EBUSY 16 Device or resource busy OK, will update per your comments. Thanks. >