Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 3/3] MIPS: eBPF: Initial eBPF support for MIPS32
 architecture.
To:     Hassan Naveed <hnaveed@wavecomp.com>,
        Paul Burton <pburton@wavecomp.com>
Cc:     "kafai@fb.com" <kafai@fb.com>,
        "songliubraving@fb.com" <songliubraving@fb.com>,
        "yhs@fb.com" <yhs@fb.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
        Ralf Baechle <ralf@linux-mips.org>,
        James Hogan <jhogan@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        "open list:MIPS" <linux-mips@linux-mips.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20190312224706.6121-1-hnaveed@wavecomp.com>
 <20190312224706.6121-3-hnaveed@wavecomp.com>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <98323a41-2851-d000-c928-242d055a5bc1@iogearbox.net>
Date:   Wed, 20 Mar 2019 15:07:20 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20190312224706.6121-3-hnaveed@wavecomp.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 03/12/2019 11:48 PM, Hassan Naveed wrote:
> Currently MIPS32 supports a JIT for classic BPF only, not extended BPF.
> This patch adds JIT support for extended BPF on MIPS32, so code is
> actually JIT'ed instead of being only interpreted. Instructions with
> 64-bit operands are not supported at this point.
> We can delete classic BPF because the kernel will translate classic BPF
> programs into extended BPF and JIT them, eliminating the need for
> classic BPF.
> 
> Signed-off-by: Hassan Naveed <hnaveed@wavecomp.com>

Nice! Did you check BPF test suite (lib/test_bpf.ko) that both before/after
the same number of cBPF programs could be JITed?

Please also follow-up to update Documentation/sysctl/net.txt, bpf_jit_enable
section, and adding yourself as co-maintainer for 'BPF JIT for MIPS' wouldn't
hurt either if Paul would be good with that, too.

Any plans on completing eBPF support for mips32?

Thanks,
Daniel