Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Robert Richter <rrichter@marvell.com>
To:     Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "Borislav Petkov" <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
        "x86@kernel.org" <x86@kernel.org>,
        Jean Delvare <jdelvare@suse.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>
CC:     Marcin Benka <mbenka@marvell.com>,
        "linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>
Subject: Re: [PATCH] efi: Unify dmi setup code over architectures arm/arm64,
 io64 and x86
Thread-Topic: [PATCH] efi: Unify dmi setup code over architectures arm/arm64,
 io64 and x86
Thread-Index: AQHU3x8X2rcfIh633keoeruImJvrSKYUmbYA
Date:   Wed, 20 Mar 2019 14:48:34 +0000
Message-ID: <20190320144828.a7iui7v5cwt45myr@rric.localdomain>
References: <20190320130502.16667-1-rrichter@marvell.com>
 <20190320131607.vgst3r7ynha55ikw@rric.localdomain>
In-Reply-To: <20190320131607.vgst3r7ynha55ikw@rric.localdomain>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [77.191.24.140]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: beb5459f-8eb4-4a66-4bde-08d6ad432072
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);SRVR:BL0PR18MB2195;
x-ms-traffictypediagnostic: BL0PR18MB2195:
x-microsoft-antispam-prvs: <BL0PR18MB21951F7750D7149F763C12D5D9410@BL0PR18MB2195.namprd18.prod.outlook.com>
x-forefront-prvs: 098291215C
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(39860400002)(346002)(136003)(396003)(376002)(189003)(199004)(76176011)(14454004)(476003)(99286004)(6506007)(305945005)(7416002)(7736002)(386003)(3846002)(26005)(53546011)(102836004)(6116002)(478600001)(446003)(86362001)(25786009)(52116002)(486006)(186003)(11346002)(4326008)(81156014)(110136005)(97736004)(8676002)(2501003)(81166006)(5660300002)(71190400001)(6436002)(316002)(4744005)(1076003)(105586002)(53936002)(6486002)(68736007)(106356001)(6512007)(229853002)(71200400001)(66066001)(9686003)(54906003)(256004)(6246003)(8936002)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:BL0PR18MB2195;H:BL0PR18MB2305.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: hjSqZ+Ei9i6Tl4F3Lf8pAM0HtLzriDruWziROd5OeFyP0IpLAL9QamfCcHvwYPvlsmh7eQdgRAGEtAybrR/i00SwfWEIt7pYRZtjlbYnct+NXf3HoXOZN1flC6tmqFZ/lYzIZwmiKu3KL44ZeroJylm5u3Y+4abxEOtQkfi5hSPcpEoSBMXxC7iia+be9L7IAOYOsmw7pQkECvGdCf653fu1+oxKEhOee4mD9GIGuBv9ZaNOtXPPaUnkJh5A1U9K1Ht1dT8Czp+U3UYP9aHel+gv5rUIoTwjBkzjT8pxy7ixnJPDFguXm50VNXr6X8PDK2JIwxvSq2SaD1HvCCdhT7nY1ZA4u4mD+CZyd39ti7BdfWR4M+oo63ZYxIDaP8lJUShTfQmCuPxVfAP+43eu4Qbp4Fk8KASgAC6l5otZk0g=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <91E9DFF65CD8DA40980FD4A23D35FDB4@namprd18.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: beb5459f-8eb4-4a66-4bde-08d6ad432072
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2019 14:48:34.4733
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR18MB2195
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-20_09:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20.03.19 13:16:13, Robert Richter wrote:

> diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/ar=
m-runtime.c
> index 4a0dfe4ab829..c250b767030e 100644
> --- a/drivers/firmware/efi/arm-runtime.c
> +++ b/drivers/firmware/efi/arm-runtime.c
> @@ -162,14 +162,10 @@ void efi_virtmap_unload(void)
>  static int __init arm_dmi_init(void)
>  {
>  	/*
> -	 * On arm64/ARM, DMI depends on UEFI, and dmi_scan_machine() needs to
> +	 * On arm64/ARM, DMI depends on UEFI, and dmi_setup() needs to
>  	 * be called early because dmi_id_init(), which is an arch_initcall
>  	 * itself, depends on dmi_scan_machine() having been called already.
>  	 */
> -	dmi_scan_machine();
> -	dmi_memdev_walk();
> -	if (dmi_available)
> -		dmi_set_dump_stack_arch_desc();

This went wrong in the last stage of a comment rework. A dmi_setup()
should be here. Will resubmit. Sorry.

-Robert

>  	return 0;
>  }