Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 42FEA6030B
From:   Mukesh Ojha <mojha@codeaurora.org>
Subject: Re: [PATCH] staging: rtlwifi: Fix potential NULL pointer dereference
To:     Aditya Pakki <pakki001@umn.edu>
Cc:     kjlu@umn.edu, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Nathan Chancellor <natechancellor@gmail.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
References: <20190313161336.20182-1-pakki001@umn.edu>
Message-ID: <34641591-82d9-d76b-eb33-265a124d4923@codeaurora.org>
Date:   Wed, 20 Mar 2019 20:36:54 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20190313161336.20182-1-pakki001@umn.edu>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/13/2019 9:43 PM, Aditya Pakki wrote:
> phydm.internal is allocated using kzalloc which is used multiple
> times without a check for NULL pointer. This patch avoids such a
> scenario.
>
> Signed-off-by: Aditya Pakki<pakki001@umn.edu>
> ---
>   drivers/staging/rtlwifi/phydm/rtl_phydm.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/rtlwifi/phydm/rtl_phydm.c b/drivers/staging/rtlwifi/phydm/rtl_phydm.c
> index 9930ed954abb..37c7fcb72b65 100644
> --- a/drivers/staging/rtlwifi/phydm/rtl_phydm.c
> +++ b/drivers/staging/rtlwifi/phydm/rtl_phydm.c
> @@ -181,6 +181,9 @@ static int rtl_phydm_init_priv(struct rtl_priv *rtlpriv,
>   	rtlpriv->phydm.internal =
>   		kzalloc(sizeof(struct phy_dm_struct), GFP_KERNEL);
>   
> +	if (!rtlpriv->phydm.internal)
> +		return -ENOMEM;
> +


Although, it is good to add a check but nobody is checking this 
functions returned value.

Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Can you fix that cleanly ? or i will do?

Cheers,
Mukesh


>   	_rtl_phydm_init_com_info(rtlpriv, ic, params);
>   
>   	odm_init_all_timers(dm);