Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Jiang, Dave" <dave.jiang@intel.com>
To:     Yue Haibing <yuehaibing@huawei.com>,
        "jdmason@kudzu.us" <jdmason@kudzu.us>,
        "allenbh@gmail.com" <allenbh@gmail.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-ntb@googlegroups.com" <linux-ntb@googlegroups.com>
Subject: RE: [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static
Thread-Topic: [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static
Thread-Index: AQHU3yZ3uGDKLKo0d0SBvFbL1g+z5aYUonfw
Date:   Wed, 20 Mar 2019 15:20:43 +0000
Message-ID: <112A412BB11A1242B37129D931BCE5348445D71E@fmsmsx117.amr.corp.intel.com>
References: <20190320140812.5952-1-yuehaibing@huawei.com>
In-Reply-To: <20190320140812.5952-1-yuehaibing@huawei.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> -----Original Message-----
> From: Yue Haibing [mailto:yuehaibing@huawei.com]
> Sent: Wednesday, March 20, 2019 7:08 AM
> To: Jiang, Dave <dave.jiang@intel.com>; jdmason@kudzu.us;
> allenbh@gmail.com
> Cc: linux-kernel@vger.kernel.org; linux-ntb@googlegroups.com; YueHaibing
> <yuehaibing@huawei.com>
> Subject: [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static
> 
> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fix sparse warning:
> 
> drivers/ntb/hw/intel/ntb_hw_gen3.c:535:5: warning:
>  symbol 'intel_ntb3_peer_db_addr' was not declared. Should it be static?

For now yes. Thanks!

Acked-by: Dave Jiang <dave.jiang@intel.com>

> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/ntb/hw/intel/ntb_hw_gen3.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/ntb/hw/intel/ntb_hw_gen3.c
> b/drivers/ntb/hw/intel/ntb_hw_gen3.c
> index f475b56..c339716 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_gen3.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_gen3.c
> @@ -532,9 +532,9 @@ static int intel_ntb3_mw_set_trans(struct ntb_dev
> *ntb, int pidx, int idx,
>  	return 0;
>  }
> 
> -int intel_ntb3_peer_db_addr(struct ntb_dev *ntb, phys_addr_t *db_addr,
> -				resource_size_t *db_size,
> -				u64 *db_data, int db_bit)
> +static int intel_ntb3_peer_db_addr(struct ntb_dev *ntb, phys_addr_t
> *db_addr,
> +				   resource_size_t *db_size,
> +				   u64 *db_data, int db_bit)
>  {
>  	phys_addr_t db_addr_base;
>  	struct intel_ntb_dev *ndev = ntb_ndev(ntb);
> --
> 2.7.0
>