Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp669571img; Wed, 20 Mar 2019 08:28:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqwda2j6oTiVkgI6w6s76bhiLn3M3ub6gGijaVqtUIdmb23j3pxcJs/T0sK7lj4CXH6UQmpE X-Received: by 2002:aa7:818a:: with SMTP id g10mr964356pfi.178.1553095698093; Wed, 20 Mar 2019 08:28:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553095698; cv=none; d=google.com; s=arc-20160816; b=aSvnuFTfrgJgLziYcakDjuTh0CwJPW0rzgtQ2Tqpb+glw0RVDtRdigmK+khZipBTAQ WZyMX4vKsWVlWvEQUca6IWsMi24NXpkbRCej4V3DMYLqxXlWmQaSRTPuBAHd2lf0HK3N mhhneMx8w6VsE3BIL1EjEMrzc/BGRzgeqCSQg7GtFQtyKz9IUVHwwpP4pRdkgyuF1/UH nIUd1sHzrRwBDNBIp8ngrwq/a7NIzY7alfbRdknv3L0s7fC4M4faPdPf0fwAMH5sk786 y4WyEWCdrybvjqLVAY4C9EDYb/4/a9uSPzi0ZepUkk9XUGo1EJDBk3W7oYvO6zdKDt+j VOQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=gRegdW0Vp32TTwcRwpYr4FmCrFCirUJNOAYEJ5vzjtw=; b=aAAZdv8nRUg/y1cC9qp63xT8fF4xo9vBoiiw6gcg30JYE4KH9c0a9ScfBDLkhXNLqf QE8EdHxpqPpOn1i1tIK2kTjApRgQDTqhl9Zig8/g6oxBd/wE5HqcK0ZmYL73XJfwwFrz XACQ1aYvRoeE7kSckoHCaVX6ADEmBOJcOdzB5uf9mQLkru65BeWHnLg1mIa6wf1aljEm J/KntN4vSNBcYCDggwpP/iWI8cy4Ph57/Wajjrpc12dZpalBvxgEiiCgVF2INhhV8tBq CpOVkmrcjiboSDvmUpFXboKrfIornmpuDtCXKUuieRNz5xh25GRP9ecRENJ/QGRs/Fiw pU8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=J3+DENYu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x22si2058010plr.111.2019.03.20.08.28.02; Wed, 20 Mar 2019 08:28:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=J3+DENYu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727123AbfCTP1S (ORCPT + 99 others); Wed, 20 Mar 2019 11:27:18 -0400 Received: from mta-p6.oit.umn.edu ([134.84.196.206]:37344 "EHLO mta-p6.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726457AbfCTP1R (ORCPT ); Wed, 20 Mar 2019 11:27:17 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p6.oit.umn.edu (Postfix) with ESMTP id 44B883F5 for ; Wed, 20 Mar 2019 15:27:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p6.oit.umn.edu ([127.0.0.1]) by localhost (mta-p6.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CW_LLI9y23XJ for ; Wed, 20 Mar 2019 10:27:15 -0500 (CDT) Received: from mail-it1-f198.google.com (mail-it1-f198.google.com [209.85.166.198]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p6.oit.umn.edu (Postfix) with ESMTPS id E3FE7BE7 for ; Wed, 20 Mar 2019 10:27:15 -0500 (CDT) Received: by mail-it1-f198.google.com with SMTP id s3so2491860itl.0 for ; Wed, 20 Mar 2019 08:27:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=gRegdW0Vp32TTwcRwpYr4FmCrFCirUJNOAYEJ5vzjtw=; b=J3+DENYuvYqwCOu+pPdJN+D2rPCmz2ActBpNZtlQS0s1N3ufbgHzTJa+pF/kc2mb89 0gCJMAW5LPC3I+KBSHvHSJGBFwCFwX+iptQ7650iMKljz8C1w5BwNuqdXwElp2LwLtZc zQh+5ANjwtAU3fFw1wtmuPtxuJY6AdHLKIbLdL0EFvH5v4FpMRvIv5tcroZkHZUJR0LY Fxpbh7UJy+hGNHeq+QdXzXx5fXljJYnVTv6STeZQ+oQYXO+p2bzTZpY9/bI3Zaz2hCXa 99Pcdz7gOYMFCg7H8lpzfcFTV/49bpdcX7RtgBBCzXfHVy9KOy+Dj2pDfzn4sVDOqtGf aB/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=gRegdW0Vp32TTwcRwpYr4FmCrFCirUJNOAYEJ5vzjtw=; b=OPI6qbWT9rZDkvyPqD836vK2K0PvyTOfxQ8W3/wjAFD71yLr87XgH7UV/d5mEuGtj+ RGLfG/j1XZlTXRn1NMcS3fXh9FLjh/0zwKaulQnpz6cKHuYSwTlhO8b6B24pjokD2pMs tfRC3XobhRwQxM8KilS3sQXBX2u/tRm7citzuiS4Ezy7RBmCEg6CoJds1l+4kkzXwqyf i6F7nEGClJEvxMhqvofoHsqhfrMORtoaaUx8zwmfk3go+xd+jLIUEaoW8ukvsfnz9ECs AUULoS4J6Jigr17ZUBTSqX6+KxCTGxOvwDshmq/I05W3ni7U3uwxiFUYI57LwMNElNgm BZDg== X-Gm-Message-State: APjAAAXIOz4CH1wo8piJpoknuZgDc9RCX3Bywjrj4QdAjsHpe7Fnxv3L xaB7L9Gvgd9gjGg7L68eUOkaaGuYbPXJO7V9uGn7BWoQGwRXIMM91PUyswsGrZ30o1G/SWMi/AO ZnkvNEYIo3vyYUQ7cmLjP/sW3tEtf X-Received: by 2002:a02:b510:: with SMTP id l16mr5491649jaj.13.1553095635464; Wed, 20 Mar 2019 08:27:15 -0700 (PDT) X-Received: by 2002:a02:b510:: with SMTP id l16mr5491615jaj.13.1553095635019; Wed, 20 Mar 2019 08:27:15 -0700 (PDT) Received: from cs-u-syssec1.dtc.umn.edu (cs-u-syssec1.cs.umn.edu. [128.101.106.66]) by smtp.gmail.com with ESMTPSA id l62sm1195945ita.12.2019.03.20.08.27.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Mar 2019 08:27:14 -0700 (PDT) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, Richard Leitner , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] usb: usb251xb: fix to avoid potential NULL pointer dereference Date: Wed, 20 Mar 2019 10:27:11 -0500 Message-Id: <20190320152711.28749-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_match_device in usb251xb_probe can fail and returns a NULL pointer. The patch avoids a potential NULL pointer dereference in this scenario. Signed-off-by: Aditya Pakki Reviewed-by: Richard Leitner --- v2: Fix version changes below sign off v1: avoid return in case of error, per Richard's suggestion. --- drivers/usb/misc/usb251xb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c index 4d72b7d1d383..bbfdb7447d6f 100644 --- a/drivers/usb/misc/usb251xb.c +++ b/drivers/usb/misc/usb251xb.c @@ -612,7 +612,7 @@ static int usb251xb_probe(struct usb251xb *hub) dev); int err; - if (np) { + if (np && of_id) { err = usb251xb_get_ofdata(hub, (struct usb251xb_data *)of_id->data); if (err) { -- 2.17.1