Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 20 Mar 2019 18:39:51 +0100
From:   Greg KH <greg@kroah.com>
To:     James Smart <james.smart@broadcom.com>
Cc:     Kees Cook <keescook@chromium.org>, Willy Tarreau <w@1wt.eu>,
        Silvio Cesare <silvio.cesare@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Dick Kennedy <dick.kennedy@broadcom.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH 5/8] scsi: lpfc: change snprintf to scnprintf for
 possible overflow
Message-ID: <20190320173951.GA27003@kroah.com>
References: <20190112152844.26550-1-w@1wt.eu>
 <20190112152844.26550-5-w@1wt.eu>
 <CAGXu5jKu5br-pB3U+3PDtgcgq_nmt0C7gHLYQXV4tz3pN=S11Q@mail.gmail.com>
 <de134f7c-7516-cfb4-7cd2-6d96b45bdb48@broadcom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <de134f7c-7516-cfb4-7cd2-6d96b45bdb48@broadcom.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 15, 2019 at 02:41:17PM -0800, James Smart wrote:
> 
> On 1/14/2019 5:15 PM, Kees Cook wrote:
> > On Sat, Jan 12, 2019 at 7:29 AM Willy Tarreau<w@1wt.eu>  wrote:
> > > From: Silvio Cesare<silvio.cesare@gmail.com>
> > > 
> > > Change snprintf to scnprintf. There are generally two cases where using
> > > snprintf causes problems.
> > > 
> > > 1) Uses of size += snprintf(buf, SIZE - size, fmt, ...)
> > > In this case, if snprintf would have written more characters than what the
> > > buffer size (SIZE) is, then size will end up larger than SIZE. In later
> > > uses of snprintf, SIZE - size will result in a negative number, leading
> > > to problems. Note that size might already be too large by using
> > > size = snprintf before the code reaches a case of size += snprintf.
> > > 
> > > 2) If size is ultimately used as a length parameter for a copy back to user
> > > space, then it will potentially allow for a buffer overflow and information
> > > disclosure when size is greater than SIZE. When the size is used to index
> > > the buffer directly, we can have memory corruption. This also means when
> > > size = snprintf... is used, it may also cause problems since size may become
> > > large.  Copying to userspace is mitigated by the HARDENED_USERCOPY kernel
> > > configuration.
> > > 
> > > The solution to these issues is to use scnprintf which returns the number of
> > > characters actually written to the buffer, so the size variable will never
> > > exceed SIZE.
> > > 
> > > Signed-off-by: Silvio Cesare<silvio.cesare@gmail.com>
> > > Cc: James Smart<james.smart@broadcom.com>
> > > Cc: Dick Kennedy<dick.kennedy@broadcom.com>
> > > Cc: Dan Carpenter<dan.carpenter@oracle.com>
> > > Cc: Kees Cook<keescook@chromium.org>
> > > Cc: Will Deacon<will.deacon@arm.com>
> > > Cc: Greg KH<greg@kroah.com>
> > > Signed-off-by: Willy Tarreau<w@1wt.eu>
> > I think this needs Cc: stable.
> > 
> > Reviewed-by: Kees Cook<keescook@chromium.org>
> > 
> > -Kees
> > 
> 
> 
> Reviewed-by:? James Smart <james.smart@broadcom.com>

What ever happened to this patch?  Did it get dropped somehow?

thanks,

greg k-h