Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Brian Starkey <Brian.Starkey@arm.com>
To:     Nicolas Dufresne <nicolas@ndufresne.ca>
CC:     Maxime Ripard <maxime.ripard@bootlin.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        David Airlie <airlied@linux.ie>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Sean Paul <seanpaul@chromium.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Hans Verkuil <hans.verkuil@cisco.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        nd <nd@arm.com>
Subject: Re: [RFC PATCH 18/20] lib: image-formats: Add v4l2 formats support
Thread-Topic: [RFC PATCH 18/20] lib: image-formats: Add v4l2 formats support
Thread-Index: AQHU30j15eYGJfx+ZkmNvpI6wq6Apw==
Date:   Wed, 20 Mar 2019 18:15:54 +0000
Message-ID: <20190320181553.radwlhapzn464dlh@DESKTOP-E1NTVVP.localdomain>
References: <cover.92acdec88ee4c280cb74e08ea22f0075e5fa055c.1553032382.git-series.maxime.ripard@bootlin.com>
 <c97024b97d3261dcf41aad3c8bc1c5d9906f33c9.1553032382.git-series.maxime.ripard@bootlin.com>
 <d8f4a31e35b1702230ced4a0cb43c10d1c7e60c8.camel@ndufresne.ca>
In-Reply-To: <d8f4a31e35b1702230ced4a0cb43c10d1c7e60c8.camel@ndufresne.ca>
Accept-Language: en-GB, en-US
Content-Language: en-US
user-agent: NeoMutt/20180716-849-147d51-dirty
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 118528bc-f306-4126-864f-08d6ad6017ac
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM0PR08MB4002;
x-ms-traffictypediagnostic: AM0PR08MB4002:
x-ms-exchange-purlcount: 1
nodisclaimer: True
x-microsoft-antispam-prvs: <AM0PR08MB40028E8548A023F72691C52FF0410@AM0PR08MB4002.eurprd08.prod.outlook.com>
x-forefront-prvs: 098291215C
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(366004)(376002)(39860400002)(346002)(136003)(189003)(199004)(256004)(386003)(97736004)(52116002)(9686003)(81156014)(76176011)(966005)(99286004)(102836004)(105586002)(106356001)(305945005)(6246003)(58126008)(72206003)(68736007)(6506007)(316002)(14454004)(54906003)(7736002)(2906002)(81166006)(478600001)(6512007)(25786009)(6306002)(8936002)(6916009)(66066001)(6116002)(1076003)(229853002)(3846002)(4326008)(86362001)(476003)(53936002)(14444005)(44832011)(5660300002)(486006)(446003)(71200400001)(71190400001)(6436002)(11346002)(8676002)(7416002)(6486002)(26005)(186003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR08MB4002;H:AM0PR08MB3025.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 2EZSvcw+CdYOaYsYpr0MeT5bkoc17Omlno6GxTi9DbLSoMCmVD0nfs9qKSGozu4zdPfXzui3jgH0TdNzjD+som1JrbtCi3IKqkUg2mdxj5Chqtl1c4a2+/BUalPxGCpHfw+5YLD6MLcTc2HOovTkBG9xKRW0sWtu1oR1OMOu63H38ynb7HbIYfoBMWciG5F0DndSSLE2av6tcviRFGEhcHBsLaojwcQpivCBUt1KPzcDC0wM/XL0JHghaOt2nUwTpOo2Y8RS8r2nN+/glcRk1KHN6LrOGzW7OxalbeV5QLSSnyj3bdOosIz4tL5qwlxtloqz3c/tdT11rSsJ2bxmymtK78cOYwDwyzLvY+/iFt6mO1C0Ho/+0f4VC4OMQ9I8oCV3iQy8oiZLEJ139HqF2lYA0XUSEUI/QJqYyjsjCA4=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4811124997DA2F4383E90C1A9A8E2083@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 118528bc-f306-4126-864f-08d6ad6017ac
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2019 18:15:54.9935
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4002
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 19, 2019 at 07:29:18PM -0400, Nicolas Dufresne wrote:
> All RGB mapping should be surrounded by ifdef, because many (not all)
> DRM formats represent the order of component when placed in a CPU
> register, unlike V4L2 which uses memory order. I've pick this one
> randomly, but this one on most system, little endian, will match
> V4L2_PIX_FMT_XBGR32. This type of complex mapping can be found in
> multiple places, notably in GStreamer:
>=20
> https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/blob/master/sys/=
kms/gstkmsutils.c#L45
>=20

I do sort-of wonder if it's worth trying to switch to common fourccs
between DRM and V4L2 (and whatever else there is).

The V4L2 formats list is quite incomplete and a little quirky in
places (V4L2_PIX_FORMAT_XBGR32 and V4L2_PIX_FORMAT_XRGB32 naming
inconsistency being one. 'X' isn't even next to 'B' in XBGR32).

At least for newly-added formats, not using a common definition
doesn't make a lot of sense to me. Longer term, I also don't really
see any downsides to unification.

-Brian