Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3272960159
Subject: Re: [PATCH -next] irqchip/brcmstb-l2: Make two init functions static
To:     Yue Haibing <yuehaibing@huawei.com>, cernekee@gmail.com,
        f.fainelli@gmail.com, tglx@linutronix.de, jason@lakedaemon.net,
        marc.zyngier@arm.com, computersforpeace@gmail.com,
        gregory.0xf0@gmail.com, bcm-kernel-feedback-list@broadcom.com
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mips@vger.kernel.org
References: <20190320142220.3224-1-yuehaibing@huawei.com>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <e1418be9-881b-3460-a820-44432d29419f@codeaurora.org>
Date:   Thu, 21 Mar 2019 01:07:01 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20190320142220.3224-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/20/2019 7:52 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warnings:
>
> drivers/irqchip/irq-brcmstb-l2.c:278:12: warning:
>   symbol 'brcmstb_l2_edge_intc_of_init' was not declared. Should it be static?
> drivers/irqchip/irq-brcmstb-l2.c:285:12: warning:
>   symbol 'brcmstb_l2_lvl_intc_of_init' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   drivers/irqchip/irq-brcmstb-l2.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c
> index 83364fe..5e4ca13 100644
> --- a/drivers/irqchip/irq-brcmstb-l2.c
> +++ b/drivers/irqchip/irq-brcmstb-l2.c
> @@ -275,14 +275,14 @@ static int __init brcmstb_l2_intc_of_init(struct device_node *np,
>   	return ret;
>   }
>   
> -int __init brcmstb_l2_edge_intc_of_init(struct device_node *np,
> +static int __init brcmstb_l2_edge_intc_of_init(struct device_node *np,
>   	struct device_node *parent)
>   {
>   	return brcmstb_l2_intc_of_init(np, parent, &l2_edge_intc_init);
>   }
>   IRQCHIP_DECLARE(brcmstb_l2_intc, "brcm,l2-intc", brcmstb_l2_edge_intc_of_init);
>   
> -int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,
> +static int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,
>   	struct device_node *parent)
>   {
>   	return brcmstb_l2_intc_of_init(np, parent, &l2_lvl_intc_init);


Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>


Thanks,
Mukesh