Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 41660602AE
Subject: Re: [PATCH -next] proc/kcore: Make kcore_modules static
To:     Yue Haibing <yuehaibing@huawei.com>, adobriyan@gmail.com,
        akpm@linux-foundation.org, osandov@fb.com, james.morse@arm.com,
        sfr@canb.auug.org.au
Cc:     linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
References: <20190320135417.13272-1-yuehaibing@huawei.com>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <6af0854e-b2c4-e5ce-ea2c-082d35f5e96e@codeaurora.org>
Date:   Thu, 21 Mar 2019 01:25:30 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20190320135417.13272-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/20/2019 7:24 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> fs/proc/kcore.c:591:19: warning:
>   symbol 'kcore_modules' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   fs/proc/kcore.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c
> index bbcc185..378f453 100644
> --- a/fs/proc/kcore.c
> +++ b/fs/proc/kcore.c
> @@ -588,7 +588,7 @@ static void __init proc_kcore_text_init(void)
>   /*
>    * MODULES_VADDR has no intersection with VMALLOC_ADDR.
>    */
> -struct kcore_list kcore_modules;
> +static struct kcore_list kcore_modules;
>   static void __init add_modules_range(void)
>   {
>   	if (MODULES_VADDR != VMALLOC_START && MODULES_END != VMALLOC_END) {


Acked-by: Mukesh Ojha <mojha@codeaurora.org>