Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Richard Weinberger <richard@nod.at>
To:     Mukesh Ojha <mojha@codeaurora.org>
Cc:     Yue Haibing <yuehaibing@huawei.com>, dedekind1@gmail.com,
        adrian.hunter@intel.com, linux-kernel@vger.kernel.org,
        linux-mtd@lists.infradead.org
Subject: Re: [PATCH -next] ubifs: remove unused function __ubifs_shash_final
Date:   Wed, 20 Mar 2019 21:18:58 +0100
Message-ID: <2691086.gDEv9kBeKS@blindfold>
In-Reply-To: <97289b81-ed73-002a-504d-2e82fad153e7@codeaurora.org>
References: <20190320140955.11576-1-yuehaibing@huawei.com> <97289b81-ed73-002a-504d-2e82fad153e7@codeaurora.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="iso-8859-1"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Am Mittwoch, 20. M?rz 2019, 21:05:37 CET schrieb Mukesh Ojha:
> 
> On 3/20/2019 7:39 PM, Yue Haibing wrote:
> > From: YueHaibing <yuehaibing@huawei.com>
> >
> > There is no callers in tree, and can be removed.
> >
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> >   fs/ubifs/auth.c | 18 ------------------
> >   1 file changed, 18 deletions(-)
> >
> > diff --git a/fs/ubifs/auth.c b/fs/ubifs/auth.c
> > index 5bf5fd0..2a40ccce 100644
> > --- a/fs/ubifs/auth.c
> > +++ b/fs/ubifs/auth.c
> > @@ -147,24 +147,6 @@ struct shash_desc *__ubifs_hash_get_desc(const struct ubifs_info *c)
> >   }
> >   
> >   /**
> > - * __ubifs_shash_final - finalize shash
> > - * @c: UBIFS file-system description object
> > - * @desc: the descriptor
> > - * @out: the output hash
> > - *
> > - * Simple wrapper around crypto_shash_final(), safe to be called with
> > - * disabled authentication.
> > - */
> > -int __ubifs_shash_final(const struct ubifs_info *c, struct shash_desc *desc,
> > -			u8 *out)
> > -{
> > -	if (ubifs_authenticated(c))
> > -		return crypto_shash_final(desc, out);
> > -
> > -	return 0;
> > -}
> > -
> > -/**
> >    * ubifs_bad_hash - Report hash mismatches
> >    * @c: UBIFS file-system description object
> >    * @node: the node
> 
> 
> 
> Looks fine to be removed.
> 
> Acked-by: Mukesh Ojha <mojha@codeaurora.org>

I guess you mean Reviewed-by?

Thanks,
//richard