Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1553114672.2015.4.camel@gmail.com>
Subject: Re: dell_smbios KASAN bug
From:   Tom Zanussi <tzanussi@gmail.com>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Pali =?ISO-8859-1?Q?Roh=E1r?= <pali.rohar@gmail.com>,
        Mario Limonciello <mario.limonciello@dell.com>,
        linux-kernel@vger.kernel.org
Date:   Wed, 20 Mar 2019 15:44:32 -0500
In-Reply-To: <20190320163227.3aa924c2@gandalf.local.home>
References: <1553106560.2080.5.camel@gmail.com>
         <20190320144146.08ecd5e4@gandalf.local.home>
         <1553108749.2079.1.camel@gmail.com>
         <20190320151353.1a223c0e@gandalf.local.home>
         <1553110221.2034.1.camel@gmail.com>
         <20190320154534.46ebab51@gandalf.local.home>
         <1553113736.2015.2.camel@gmail.com>
         <20190320163227.3aa924c2@gandalf.local.home>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2019-03-20 at 16:32 -0400, Steven Rostedt wrote:
> On Wed, 20 Mar 2019 15:28:56 -0500
> Tom Zanussi <tzanussi@gmail.com> wrote:
> 
> > > > Unfortunately, no.  
> > > 
> > > That's really weird. I would recommend throwing in a bunch of
> > > printks
> > > to see if things are being freed and set, to make sure this code
> > > is
> > > hit
> > > and something else isn't just corrupting it.
> > >   
> > 
> > Actually the patch does make the KASAN bug go away - I'm so used to
> > building without modules that I forgot to rebuild the module after
> > applying the patch, sigh.
> 
> I wasn't about to say anything. That's why I suggested adding printks
> and trying it again ;-)
> 

Yeah, when a simple printk doesn't work, you know there's something
idiotic going on.  Thanks for the tip ;-)

Tom

> -- Steve