Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp115722img; Wed, 20 Mar 2019 15:29:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqzAgGaap+GjtfgEgHzWrovW2XPTgeUqkNLiTEGkKENpiempVCvSt+6TJSKvQ6kzAxGmpSfk X-Received: by 2002:a63:e850:: with SMTP id a16mr306469pgk.195.1553120978993; Wed, 20 Mar 2019 15:29:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553120978; cv=none; d=google.com; s=arc-20160816; b=x23VYmoR3TGMxrlOPEQ1IG8IOMO2PSa0787+sTiBp+VkUE01/J6XwEb8CGisSQlWYm rFjJYgBPAR79kycqqRx9I5YmDD4CejL5mOwkAN1Z86JVv2t7/Ln1NhTBklEduJvpShVC NTwYHeH+SXfUc2EqzGMuGUWRUvZsMtpgwdNr8k7ewRSvY4q13yjbkzf4OWmtOJOf/peU t6axhXJsnT5EiVsXeI+kGOCDpPzgrmPY2PKV05MBmzKf6AKG8yjCg066k48xHtaSdu12 85HGmbPEtMLAMgtTI8r7pzSCOCDXOtVjnV67NksFBKKbYAAQvUOAamJmapP3jPPNe+i5 z0ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=dLQbQLb+LbBg3EhbjazMgrlxpCtWNa1jT7fqdBlxHDI=; b=NLFiDIs65XK35CwEPLdabHelqaZF0Pip+TYi2XhN3fzXs0kGvYZ70eDd7euJk8xSs7 d2ACVYF4aqcJGYukQrN4fY1gn9BuGdyXnJYWauyF4QG2REKurHQALlQUSQWIQ0nPhgSZ 9JiOWCpg4yrBsJn3/XFtMC2Q0n3mS7JQ+DHs83jX0VTLPycooWmaDyWZ0a9xeSfnwFDr cn+rJLh0Mpda4c8CmiWn2Gof6LHmqY08fnOz0TcyboaF4Y/iaIpP9xI/Fw2WxYR5C/Mx QR0M/jXT+igFMT/uFnI2YEPUQ5H1ZqcwbFuaK5/1QcX/jPi2POKRBKpd5pljDseA9WC0 hR5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g6si2596294pgk.478.2019.03.20.15.29.22; Wed, 20 Mar 2019 15:29:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727645AbfCTW2o (ORCPT + 99 others); Wed, 20 Mar 2019 18:28:44 -0400 Received: from mail-yw1-f68.google.com ([209.85.161.68]:44679 "EHLO mail-yw1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727540AbfCTW2o (ORCPT ); Wed, 20 Mar 2019 18:28:44 -0400 Received: by mail-yw1-f68.google.com with SMTP id c4so3315515ywa.11; Wed, 20 Mar 2019 15:28:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dLQbQLb+LbBg3EhbjazMgrlxpCtWNa1jT7fqdBlxHDI=; b=PIU1W786gGBdSihC6oNyGT5Atvhr2uKXXa6ebd6tyEQFffMOSxGFvq/M3nN+FM0X7K 2u/MV1gi8M/N5JdsmqWRr1q1/iC7irvS6vAyqws734tZyZNtHAISQFg2CRmMxislicsu rpti39rsFXD7BtL/YGrz3EQPmF6iSMiO8k4KOAifL8lxHH7hehMZKBgacJfIv/t/WOMU 6oRHwu08b2IC2L8qMrADGll2ybDVOWjxUpGA5axuow3roJtJg60gD+C3Gf8wJRT8d2Rr yTYfLHCMIiJnsouThGo+dOLx2bjfsdQXIbEWWeJppm2zJbNQzn6nVMmQMXK05es2Du/a YHpA== X-Gm-Message-State: APjAAAUsr8F50FkJgaHel3ec+ezgBpoHTKxO5YekHH2jdXtJkvKVFz8F NgyXyBTf8aQNZneVaqCWLds= X-Received: by 2002:a81:8807:: with SMTP id y7mr459608ywf.265.1553120923407; Wed, 20 Mar 2019 15:28:43 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id g1sm1051945ywf.0.2019.03.20.15.28.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Mar 2019 15:28:41 -0700 (PDT) Received: by 42.do-not-panic.com (sSMTP sendmail emulation); Wed, 20 Mar 2019 22:28:39 +0000 From: Luis Chamberlain To: akpm@linux-foundation.org, keescook@chromium.org Cc: sandeen@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain Subject: [PATCH 0/6] sysctl: add pending proc_do_large_bitmap fix Date: Wed, 20 Mar 2019 22:28:25 +0000 Message-Id: <20190320222831.8243-1-mcgrof@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew, Kees, Eric sent a fix out for proc_do_large_bitmap() last month for when using a large input buffer. After patch review a test case for the issue was built and submitted. I noticed there were a few issues with the tests, but instead of just asking Eric to address them I've taken care of them and ammended the commit where necessary. There's a few issues he reported which I also address and fix in this series. Since we *do* expect users of these scripts to also use them on older kernels, I've also addressed not breaking calling the script for them, and gives us an easy way to easily extend our tests cases for future kernels as well. Before anyone considers these for stable as minor fixes, I'd recommend we also address the discrepancy on the read side of things: modify the test script to use diff against the target file instead of using the temp file. Eric Sandeen (2): test_sysctl: add proc_do_large_bitmap() test case sysctl: Fix proc_do_large_bitmap for large input buffers Luis Chamberlain (4): test_sysctl: remove superfluous test_reqs() test_sysctl: load module before testing for it test_sysctl: ignore diff output on verify_diff_w() test_sysctl: allow graceful use on older kernels kernel/sysctl.c | 30 ++++- lib/test_sysctl.c | 18 ++- tools/testing/selftests/sysctl/sysctl.sh | 161 +++++++++++++++++++---- 3 files changed, 178 insertions(+), 31 deletions(-) -- 2.18.0